fix: confirm ESLint warning fixes are complete and correct in acquisition frontend - #121
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix: resolve all ESLint warnings in acquisition frontend
fix: confirm ESLint warning fixes are complete and correct in acquisition frontend
Mar 19, 2026
loopback
marked this pull request as ready for review
March 19, 2026 21:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer follow-up on PR fixing ESLint warnings in the acquisition frontend. Four automated review comments were raised; all were evaluated against actual call sites and determined to be either pre-existing issues out of scope or inapplicable.
Review outcomes
system.js'heightMap'vs'HeightMap'casing — pre-existing bug, unrelated to the==→===change; no regression introducedAcquisitionApi.jsuseState([])without setter —setKeypointsremoval was the lint fix; retaininguseStateis acceptable since the value is passed via context and guarded downstreamviewer.js:115guiElement !== undefined— both call sites (SmplBrowser.js,Annotator.js) constructVieweronly inside post-mount callbacks, soguiRef.currentis always populated;!= nullwould reintroduce the lint warning being fixedviewer.js:292this.system.smpl !== undefined—smplis never explicitly set tonull;!== undefinedcorrectly matches the actual state transitionsSub-PR #119 was a net no-op (truthiness check applied then reverted). No code changes result from this review pass.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.