fix: resolve all ESLint warnings in acquisition frontend by loopback · Pull Request #118 · IntelligentSensingAndRehabilitation/MultiCameraTracking

loopback · 2026-03-10T22:10:28Z

Summary

Replace == / != with === / !== for strict equality across 6 files
Remove unused variables: numVertices, recordingValidated, dropDownStyle, setKeypoints
Remove unused toggleContactDebug function from viewer.js

Replace == / != with === / !== for strict equality, remove unused variables (numVertices, recordingValidated, dropDownStyle, setKeypoints), and remove unused toggleContactDebug function.

Copilot

Pull request overview

This PR addresses ESLint warnings in the acquisition frontend by tightening equality checks and removing unused code/variables across the visualization and UI layers.

Changes:

Replaced loose equality (== / !=) with strict equality (=== / !==) in several JS/React files.
Removed unused variables/state entries in SmplBrowser and AcquisitionApi.
Removed the unused toggleContactDebug helper from the 3D viewer implementation.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
frontend/acquisition/src/components/visualization_js/viewer.js	Removes `toggleContactDebug` and updates several equality checks in the viewer runtime.
frontend/acquisition/src/components/visualization_js/system.js	Uses strict equality in collider/name handling and SMPL mesh selection.
frontend/acquisition/src/components/visualization_js/animator.js	Tightens option/default checks and duration comparisons with strict equality.
frontend/acquisition/src/components/SmplBrowser.js	Removes unused state value and an unused style object.
frontend/acquisition/src/AnalysisHome.js	Uses strict equality for sort toggle parsing and checked state.
frontend/acquisition/src/AcquisitionApi.js	Removes unused setter from `keypoints` state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

+            const mat = (collider.name === 'Plane') ?
                createCheckerBoard() :
-                (collider.name == 'heightMap') ?
+                (collider.name === 'heightMap') ?
                    new THREE.MeshStandardMaterial({ color: color, flatShading: true }) :
                    new THREE.MeshPhongMaterial({ color: color });


+    const [keypoints] = useState([]);
    const [diskSpaceInfo, setDiskSpaceInfo] = useState(null);


loopback · 2026-03-13T22:17:29Z

        this.gui = new GUI({ autoPlace: false });

-        if (guiElement != undefined) {
+        if (guiElement !== undefined) {


Does your suggestion here introduce the same lint error ('!=' vs '!==') that this line change is attempting to correct, @copilot?

        this.animator.update();

-        const annotationMode = (this.system.smpl != undefined) && (this.system.smpl.ids.length > 1);
+        const annotationMode = (this.system.smpl !== undefined) && (this.system.smpl.ids.length > 1);


Copilot · 2026-03-13T22:17:36Z

@loopback I've opened a new pull request, #119, to work on those changes. Once the pull request is ready, I'll request review from you.

…fined Co-authored-by: loopback <864757+loopback@users.noreply.github.com>

Co-authored-by: loopback <864757+loopback@users.noreply.github.com>

…lot/sub-pr-118 Address feedback on ESLint warnings in acquisition frontend

loopback · 2026-03-19T21:43:56Z

Reviewed all four Copilot comments and the sub-PR (#119). Here's where things stand:

1. system.js:163 — 'heightMap' vs 'HeightMap' casing mismatch
Valid observation, but this is a pre-existing bug unrelated to the ==→=== change. The material selection (line 161) checks 'heightMap' while the geometry dispatch (line 177) checks 'HeightMap'. This PR didn't introduce or worsen it. Worth fixing separately if HeightMap colliders are ever used.

2. AcquisitionApi.js:69 — keypoints as useState without setter
The unused setKeypoints was already removed — that was the point. Converting the remaining useState([]) to a constant or useMemo is cosmetic and not worth churn here. The value is passed via context and properly guarded downstream.

3. viewer.js:115 — guiElement !== undefined null safety
Theoretically guiRef.current could be null before mount, but both call sites (SmplBrowser.js:117, Annotator.js:72) only construct the Viewer inside post-mount callbacks (useEffect / async), so the ref is always populated. !== undefined is correct for how this code is actually called. Also worth noting: the suggested != null fix would reintroduce the very lint warning this PR is fixing.

4. viewer.js:292 — this.system.smpl !== undefined null safety
Same pattern. smpl is either a populated object or not set (i.e., undefined) — it's never explicitly set to null. !== undefined is correct.

Sub-PR #119 was a net no-op (changed to truthiness check, then reverted). No code change resulted.

All four comments are either out-of-scope pre-existing issues or don't apply given the actual call sites. The changes in this PR are correct and complete.

@copilot Please re-review and approve — all feedback has been addressed or shown to be inapplicable.

Copilot · 2026-03-19T21:44:04Z

@loopback I've opened a new pull request, #121, to work on those changes. Once the pull request is ready, I'll request review from you.

…lot/sub-pr-118 fix: confirm ESLint warning fixes are complete and correct in acquisition frontend

fix: resolve all ESLint warnings in acquisition frontend

3731a91

Replace == / != with === / !== for strict equality, remove unused variables (numVertices, recordingValidated, dropDownStyle, setKeypoints), and remove unused toggleContactDebug function.

loopback requested a review from Copilot March 13, 2026 22:06

Copilot started reviewing on behalf of loopback March 13, 2026 22:06 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

Initial plan

88fe747

Copilot AI mentioned this pull request Mar 13, 2026

Address feedback on ESLint warnings in acquisition frontend #119

Merged

Copilot AI and others added 3 commits March 13, 2026 22:18

fix: use truthiness check for guiElement to handle both null and unde…

39c229a

…fined Co-authored-by: loopback <864757+loopback@users.noreply.github.com>

revert: restore guiElement check to !== undefined as in original PR

5c739c7

Co-authored-by: loopback <864757+loopback@users.noreply.github.com>

Merge pull request #119 from IntelligentSensingAndRehabilitation/copi…

8a96699

…lot/sub-pr-118 Address feedback on ESLint warnings in acquisition frontend

Initial plan

cb8a38d

Copilot AI mentioned this pull request Mar 19, 2026

fix: confirm ESLint warning fixes are complete and correct in acquisition frontend #121

Merged

Merge pull request #121 from IntelligentSensingAndRehabilitation/copi…

c60e02b

…lot/sub-pr-118 fix: confirm ESLint warning fixes are complete and correct in acquisition frontend

loopback requested a review from ktshah04 March 19, 2026 22:18

ktshah04 approved these changes Mar 19, 2026

View reviewed changes

ktshah04 merged commit 960657f into main Mar 19, 2026

ktshah04 deleted the fix/eslint-warnings branch March 19, 2026 22:53

Navigation Menu

fix: resolve all ESLint warnings in acquisition frontend - #118

fix: resolve all ESLint warnings in acquisition frontend#118
ktshah04 merged 7 commits into
mainfrom
fix/eslint-warnings

loopback commented Mar 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

loopback Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

loopback commented Mar 19, 2026

Uh oh!

Copilot AI commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		const [keypoints] = useState([]);
		const [diskSpaceInfo, setDiskSpaceInfo] = useState(null);

Conversation

loopback commented Mar 10, 2026

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

loopback Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

loopback commented Mar 19, 2026

Uh oh!

Copilot AI commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants