Address feedback on ESLint warnings in acquisition frontend - #119
Merged
Merged
Conversation
…fined Co-authored-by: loopback <864757+loopback@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on ESLint warnings in acquisition frontend
fix: use truthiness check for guiElement to handle null and undefined without lint violation
Mar 13, 2026
loopback
marked this pull request as ready for review
March 13, 2026 22:23
Collaborator
|
@copilot I don't see why the distinction matters and the line cannot be left as submitted in the original pull request, given that further changes require more testing. |
Collaborator
|
@copilot I don't see why the distinction matters and the line cannot be left as submitted in the original pull request, given that further changes require more testing. |
Co-authored-by: loopback <864757+loopback@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
fix: use truthiness check for guiElement to handle null and undefined without lint violation
Address feedback on ESLint warnings in acquisition frontend
Mar 13, 2026
loopback
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
guiElementcheck inviewer.jswas reverted to!== undefinedas submitted in the original PR (#118), keeping the ESLinteqeqeqrule satisfied. No further changes were made beyond what was already submitted in the original pull request.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.