Conversation
Run go vet/build/test on ubuntu-latest (portable scalar C++ path) and ubuntu-24.04-arm (native NEON kernels), each with CGO_ENABLED=1 and 0, plus a gofmt check. docker-verify is deliberately not run in CI since the hosted runners already cover both Linux arches natively. Also make TestBadgerDBConnection hermetic: point Badger at t.TempDir() instead of config.yaml's machine-specific absolute path, which doesn't exist on CI runners and leaked state between local runs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
config.yaml pointed storage.path and badger.path at an absolute macOS path from another machine, breaking any fresh checkout. Switch both to the relative "data" directory (BadgerDB v4 creates missing dirs on open; the logger already MkdirAll's file-sink dirs), fill in Logging and Badger defaults in DefaultConfig() to match, document the logging/badger sections in the README config example, and update the CLAUDE.md known- quirks note. data/ and logs/ were already gitignored. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The live stack is internal/engine + internal/index (HNSW) + persistence (BadgerDB), with cmd/vectordb, cmd/vectordb-server, and cmd/bench as entry points. Remove the obsolete scaffolding it superseded: - db/ (engine.go, badger_test.go) and storage/ (vector.go, vectorStore.go, simpleVectorStore.go): the legacy brute-force engine cluster, plus cmd/main.go, its only demo consumer. The public vectormath.CosineSimilarityMany batch API the old engine called is kept (benchmarked, documented SIMD core API). - scratchpad.go: throwaway package-main experiment at the repo root. - pkg/types: unused float64 MathVector type and its methods (NewMathVector, Dot, Magnitude, CosineSimilarity), plus the package Log var that existed only for MathVector's warning path. - mempool: MemPool.Search and calculateSimilarity (byte-wise cosine) had no callers anywhere; also drop their private support decls (SearchResult, Block, ErrInvalidK, ErrInvalidDataType). The rest of the mempool/LRU cache is untouched. - Docs: drop the db/, storage/ entries from the README project tree and CLAUDE.md architecture overview; reword the two db/engine.go references in README and docs/simd-benchmark-report.md. go mod tidy is a no-op: every dependency of the removed code is still used by live code. Verified: CGO_ENABLED=1 and CGO_ENABLED=0 go test ./... pass, go vet ./... and go build ./... clean, gofmt -l . empty. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
# Conflicts: # db/badger_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.