Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merging this PR will not alter performance
Comparing Footnotes
|
ksbharaj
force-pushed
the
codex/plain-sketch-point-colors
branch
from
September 9, 2026 18:00
3f57d23 to
a015a9d
Compare
ksbharaj
force-pushed
the
codex/plain-sketch-point-colors
branch
from
September 11, 2026 17:36
802deff to
f5bb4d5
Compare
ksbharaj
force-pushed
the
codex/plain-sketch-point-colors
branch
from
September 12, 2026 22:35
3fb5629 to
64f55d7
Compare
ksbharaj
force-pushed
the
codex/plain-sketch-point-colors
branch
from
September 13, 2026 01:36
64f55d7 to
04a22e8
Compare
This was referenced Sep 14, 2026
ksbharaj
force-pushed
the
codex/plain-sketch-point-colors
branch
from
September 14, 2026 18:55
70b856e to
4daa679
Compare
ksbharaj
marked this pull request as ready for review
September 14, 2026 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Render each sketch point using its own solver freedom rather than inheriting the colour of its owning segment.
For example, a constrained circle centre stays white even when the circle stroke is blue because another circle parameter remains free. This corrects the display; it does not change solver behaviour or constraint requirements.
Remove the now-unused point-owner field and cover free, fixed and conflicting point/segment colour combinations in renderer tests. The segment stroke retains its own constraint colour.
Scope
This PR is now point colours only, following the code owner's request to separate duplicate-name handling from constraint/DOF display changes. Instance selection is in #13882; execution performance/cancellation is in #13883, stacked on #13882. No region or segment-selection overlays are included.
The previously tested combined commit
70b856e29374d84ca2f0ca5707e0b2b427b551c9is preserved oncodex/sketch-visualization-tested-combined. Existing MCP/TTC pins still reference that complete build during review; this narrowed PR alone is not the full native dependency required by MCP #248.