Skip to content

Fix sketch point constraint colours - #13734

Open
ksbharaj wants to merge 1 commit into
mainfrom
codex/plain-sketch-point-colors
Open

ksbharaj wants to merge 1 commit into
mainfrom
codex/plain-sketch-point-colors

Conversation

@ksbharaj

@ksbharaj ksbharaj commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Render each sketch point using its own solver freedom rather than inheriting the colour of its owning segment.

For example, a constrained circle centre stays white even when the circle stroke is blue because another circle parameter remains free. This corrects the display; it does not change solver behaviour or constraint requirements.

Remove the now-unused point-owner field and cover free, fixed and conflicting point/segment colour combinations in renderer tests. The segment stroke retains its own constraint colour.

Scope

This PR is now point colours only, following the code owner's request to separate duplicate-name handling from constraint/DOF display changes. Instance selection is in #13882; execution performance/cancellation is in #13883, stacked on #13882. No region or segment-selection overlays are included.

The previously tested combined commit 70b856e29374d84ca2f0ca5707e0b2b427b551c9 is preserved on codex/sketch-visualization-tested-combined. Existing MCP/TTC pins still reference that complete build during review; this narrowed PR alone is not the full native dependency required by MCP #248.

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modeling-app Ready Ready Preview Sep 14, 2026 7:03pm UTC

Request Review

@codspeed-hq

codspeed-hq Bot commented Sep 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 150 untouched benchmarks
⏩ 128 skipped benchmarks1


Comparing codex/plain-sketch-point-colors (4daa679) with main (081a5bf)2

Open in CodSpeed

Footnotes

  1. 128 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (2bdb7a0) during the generation of this report, so 081a5bf was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ksbharaj
ksbharaj force-pushed the codex/plain-sketch-point-colors branch from 64f55d7 to 04a22e8 Compare September 13, 2026 01:36
@ksbharaj
ksbharaj force-pushed the codex/plain-sketch-point-colors branch from 70b856e to 4daa679 Compare September 14, 2026 18:55
@ksbharaj ksbharaj changed the title Fix sketch point colours and select duplicate sketch instances Fix sketch point constraint colours Sep 14, 2026
@ksbharaj
ksbharaj marked this pull request as ready for review September 14, 2026 21:27
@ksbharaj
ksbharaj requested a review from a team as a code owner September 14, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant