Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 14, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
ksbharaj
force-pushed
the
codex/sketch-execution-performance
branch
from
September 15, 2026 04:49
3753dff to
b91eaeb
Compare
ksbharaj
marked this pull request as ready for review
September 15, 2026 12:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Render eligible first sketch instances without executing unrelated solids and booleans, and stop background native execution when the Python await is cancelled.
try_render_sketch_instanceand its code-string counterpart. Unsupported cases returnNoneso MCP can use ordinary execution.sin, and an optional named region feeding the helper's extrusion.Scope and dependencies
Split from #13734. This PR is stacked on #13882 (
codex/sketch-instance-selection); its diff is only performance and cancellation regression coverage. The point-colour change in #13734 is independent. No region/segment visualization is included, and this split adds no new optimization cases or behavioural changes. A subsequent safety fix declines the shortcut if removing a referenced outer binding could change the sketch’s meaning, falling back to ordinary execution.The previously tested combined commit
70b856e29374d84ca2f0ca5707e0b2b427b551c9is preserved oncodex/sketch-visualization-tested-combined. Existing MCP/TTC pins stay there until the reviewed pieces are available together in a published native release.Reviewer focus
spawn_pyimplementation from Cancel native KCL tasks with Python callers #13859; this PR no longer changes that wrapper. Cancellation is cooperative. In-flight integration tests relay a real DEV engine connection, confirm socket closure after direct cancellation or timeout, then check a subsequent call succeeds.The equivalence regressions compare full and optimized PNG bytes, constraint reports and placement. Saved real Flanges checkpoints motivated the optimization: two historical 519/619-second calls rendered byte-identical PNGs in approximately 1.7/1.8 seconds with the shortcut. These are focused tool benchmarks, not a controlled claim about total Zookeeper runtime. On the same newer build, a full-execution comparison hit its 240-second cap, so no precise end-to-end speedup ratio is claimed.