Repository navigation
chore(lint): reorder providers/azure structs for fieldalignment - #593
Merged
Merged
Conversation
Reorder struct fields to the fieldalignment-optimal layout. serviceResult and the AssertConsumptionUnitVariants table get keyed or reordered literals so the reorder cannot silently reassign values. Client in services/savingsplans/client.go keeps its order with a nolint because open PR #491 modifies that file. Part of #100 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 23 billable files and costs up to $5.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 5 minutes for your next included review. View limit details
Comment |
…r in providers/azure Rebuild each reordered struct body so every field keeps its own doc comment directly above it and group headers head only the fields they describe (repeated per contiguous run where the layout splits a group). Documented fields are blank-line separated so no undocumented field sits under another field comment. Part of #100 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
Merge gate verdict (claude-cc-libs)Every gate holds at head c1e6349:
CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging. |
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #100. Third of four per-module PRs; the
.golangci.ymlchange lands in the last one.Changes
providers/azurestruct fields to the fieldalignment-optimal layout (42 findings).serviceResultand theAssertConsumptionUnitVariantstable use keyed or reordered literals so the reorder cannot silently reassign values.//nolint:govet // fieldalignment: file owned by open PR #491onClientinservices/savingsplans/client.go. Other files touched by fix(azure): count savings plans billed to another subscription in the duplicate check #491 and fix(azure/compute): skip scope checks on terminal VM reservations #439 have no findings.Checks
unsafe.Sizeoforbinary.Read/Writeon these structs; cli, mcp and platform at origin/main have no unkeyed composite literals of module structs (AST scan).go build,go vet,go test -timeout 300s -count=1 ./...and golangci-lint (fieldalignment enabled, tests excluded as in the cli) pass inproviders/azure, with and withoutGOWORK=off.🤖 Generated with Claude Code