Skip to content

chore(test): point Azure RI-exchange credential test comments at cli#932 - #1225

Draft
IAmJSD wants to merge 1 commit into
LeanerCloud:mainfrom
IAmJSD:fix/issue-26
Draft

IAmJSD wants to merge 1 commit into
LeanerCloud:mainfrom
IAmJSD:fix/issue-26

Conversation

@IAmJSD

@IAmJSD IAmJSD commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Root cause and fix

Merged LeanerCloud/cloud-commitments-cli#934 fixed LeanerCloud/cloud-commitments-cli#932 (Azure RI-exchange per-subscription credential resolution). Its branch was named fix/871-azure-ri-credentials, so two test comments for that work in internal/api/handler_ri_exchange_test.go cite issue #871. LeanerCloud/cloud-commitments-cli#871 is a different issue: the design question about whether RI Exchange should honor the Main Header global filter. The issue mentions lines ~811 and ~829. The file has grown since, and those comments are now at lines 1425 and 1443.

This PR changes only those two comments to issue LeanerCloud/cloud-commitments-cli#932. It keeps the file's issue #N wording but adds the repo name, because a bare #932 here would link to this repo's PR #932, which is unrelated.

Comment-only change. No code, test logic or behavior changes.

References left alone on purpose

I checked every 871 hit from git grep -n 871. These ones really do mean cli#871 (the RI Exchange global-filter scoping), so I left them unchanged:

  • internal/api/handler_ri_exchange.go:1451: listConvertibleRIs honoring the ?account_id= global account filter
  • internal/api/handler_ri_exchange_test.go:35 and :59: the AWS convertible-RI account-scope tests
  • frontend/src/...: the global-filter scoping comments. These are correct, and frontend is out of scope anyway.
  • The rest are unrelated: line numbers in docs/audits, a commit SHA in known_issues/, and hashes in go.work.sum and the Terraform lock files.

Verification

No regression test: nothing a test could check changes, since only comments change. Evidence is local, on macOS:

  • go build ./internal/api/: OK
  • go vet ./internal/api/: OK
  • gofmt -l internal/api/handler_ri_exchange_test.go: no output
  • git diff --check: clean
  • AWS_CONFIG_FILE=/dev/null AWS_SHARED_CREDENTIALS_FILE=/dev/null go test ./internal/api/ -count=1 -v -run '^(<all 76 Test* funcs in handler_ri_exchange_test.go>)$': 76 PASS, 0 FAIL/SKIP. The AWS env vars only work around a broken local ~/.aws/config default profile.
  • AWS_CONFIG_FILE=/dev/null AWS_SHARED_CREDENTIALS_FILE=/dev/null go test ./internal/mocks/ -count=1: ok
  • golangci-lint v2.10.1 run --allow-parallel-runners ./internal/api/: 0 issues
  • git-secrets 1.3.0 --scan --cached on the changed file, in a fresh git init temp repo with an isolated HOME, using scripts/setup-git-secrets.sh and .gitallowed: clean. scripts/test-git-secrets-allowlist.sh: 137 PASS, 0 FAIL.
  • gocyclo: no non-test Go changed, so nothing to check.

Open PRs that edit handler_ri_exchange_test.go (#1108, #1121, #1159, #1175, #1191) don't touch lines 1420-1450, so this PR shouldn't conflict with them.

Out of scope

  • The cli#934 branch name fix/871-azure-ri-credentials lives in the merged history of another repo and can't be changed.

Maintainer: please mirror the issue's triage labels on this PR: impact/internal, type/chore, triaged, priority/p3, severity/low, urgency/eventually, effort/xs.

Closes #26

🤖 Generated with Claude Code

The Azure credential-resolution tests in handler_ri_exchange_test.go cite
issue LeanerCloud#871, but that work is LeanerCloud/cloud-commitments-cli#932 (fixed by
cli#934, whose branch name carried the wrong number). cli#871 is the RI
Exchange global-filter design question, so the other LeanerCloud#871 references in the
file and in handler_ri_exchange.go are correct and stay as they are. Use the
full repo-qualified form so the reference cannot be read as this repo's LeanerCloud#932.

Comment-only change; no behavior change.

Closes LeanerCloud#26

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@IAmJSD IAmJSD added impact/internal Team-internal only type/chore Maintenance / non-user-visible triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/eventually No deadline effort/xs Trivial / one-liner labels Oct 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/xs Trivial / one-liner impact/internal Team-internal only priority/p3 Polish / idea / may never ship severity/low Minor harm triaged Item has been triaged type/chore Maintenance / non-user-visible urgency/eventually No deadline

Projects

None yet

1 participant