Repository navigation
Conversation
The Azure credential-resolution tests in handler_ri_exchange_test.go cite issue LeanerCloud#871, but that work is LeanerCloud/cloud-commitments-cli#932 (fixed by cli#934, whose branch name carried the wrong number). cli#871 is the RI Exchange global-filter design question, so the other LeanerCloud#871 references in the file and in handler_ri_exchange.go are correct and stay as they are. Use the full repo-qualified form so the reference cannot be read as this repo's LeanerCloud#932. Comment-only change; no behavior change. Closes LeanerCloud#26 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause and fix
Merged LeanerCloud/cloud-commitments-cli#934 fixed LeanerCloud/cloud-commitments-cli#932 (Azure RI-exchange per-subscription credential resolution). Its branch was named
fix/871-azure-ri-credentials, so two test comments for that work ininternal/api/handler_ri_exchange_test.gocite issue #871. LeanerCloud/cloud-commitments-cli#871 is a different issue: the design question about whether RI Exchange should honor the Main Header global filter. The issue mentions lines ~811 and ~829. The file has grown since, and those comments are now at lines 1425 and 1443.This PR changes only those two comments to
issue LeanerCloud/cloud-commitments-cli#932. It keeps the file'sissue #Nwording but adds the repo name, because a bare#932here would link to this repo's PR #932, which is unrelated.Comment-only change. No code, test logic or behavior changes.
References left alone on purpose
I checked every
871hit fromgit grep -n 871. These ones really do mean cli#871 (the RI Exchange global-filter scoping), so I left them unchanged:internal/api/handler_ri_exchange.go:1451:listConvertibleRIshonoring the?account_id=global account filterinternal/api/handler_ri_exchange_test.go:35and:59: the AWS convertible-RI account-scope testsfrontend/src/...: the global-filter scoping comments. These are correct, and frontend is out of scope anyway.docs/audits, a commit SHA inknown_issues/, and hashes ingo.work.sumand the Terraform lock files.Verification
No regression test: nothing a test could check changes, since only comments change. Evidence is local, on macOS:
go build ./internal/api/: OKgo vet ./internal/api/: OKgofmt -l internal/api/handler_ri_exchange_test.go: no outputgit diff --check: cleanAWS_CONFIG_FILE=/dev/null AWS_SHARED_CREDENTIALS_FILE=/dev/null go test ./internal/api/ -count=1 -v -run '^(<all 76 Test* funcs in handler_ri_exchange_test.go>)$': 76 PASS, 0 FAIL/SKIP. The AWS env vars only work around a broken local~/.aws/configdefault profile.AWS_CONFIG_FILE=/dev/null AWS_SHARED_CREDENTIALS_FILE=/dev/null go test ./internal/mocks/ -count=1: okgolangci-lintv2.10.1run --allow-parallel-runners ./internal/api/: 0 issues--scan --cachedon the changed file, in a freshgit inittemp repo with an isolated HOME, usingscripts/setup-git-secrets.shand.gitallowed: clean.scripts/test-git-secrets-allowlist.sh: 137 PASS, 0 FAIL.Open PRs that edit
handler_ri_exchange_test.go(#1108, #1121, #1159, #1175, #1191) don't touch lines 1420-1450, so this PR shouldn't conflict with them.Out of scope
fix/871-azure-ri-credentialslives in the merged history of another repo and can't be changed.Maintainer: please mirror the issue's triage labels on this PR:
impact/internal,type/chore,triaged,priority/p3,severity/low,urgency/eventually,effort/xs.Closes #26
🤖 Generated with Claude Code