Skip to content

chore(test): point Azure RI-exchange credential test comments at cli#932 #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
IAmJSD wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Draft

chore(test): point Azure RI-exchange credential test comments at cli#932 #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions internal/api/handler_ri_exchange_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1422,7 +1422,7 @@ func TestListExchangeableAzureRIs_SubscriptionIDFiltersToOwnRows(t *testing.T) {
}
}

// --- Azure credential-resolution path tests (issue #871) ---
// --- Azure credential-resolution path tests (issue LeanerCloud/cloud-commitments-cli#932) ---
//
// These tests exercise the production path of buildAzureExchangeClient, which
// was previously hardcoded to azidentity.NewDefaultAzureCredential. The fix
Expand All @@ -1440,8 +1440,9 @@ func TestListExchangeableAzureRIs_SubscriptionIDFiltersToOwnRows(t *testing.T) {
// TestListExchangeableAzureRIs_NoAzureAccountRegistered verifies that when no
// Azure CloudAccount is registered for the requested subscription, the handler
// returns an empty reservations list (graceful empty state) rather than a 500.
// This is the fix for issue #871: Lambda has no ambient Azure identity so the
// old DefaultAzureCredential call failed, producing an opaque 500.
// This is the fix for issue LeanerCloud/cloud-commitments-cli#932: Lambda has no
// ambient Azure identity so the old DefaultAzureCredential call failed,
// producing an opaque 500.
func TestListExchangeableAzureRIs_NoAzureAccountRegistered(t *testing.T) {
mockStore := &MockConfigStore{}
// GetCloudAccountByExternalID returns (nil, nil) — no account for this sub.
Expand Down
Loading