Skip to content

fix(nc36): replace deprecated Nextcloud Vue props - #9137

Merged
vitormattos merged 2 commits into
mainfrom
fix/nc36-deprecated-vue-props
Oct 21, 2026
Merged

vitormattos merged 2 commits into
mainfrom
fix/nc36-deprecated-vue-props

Conversation

@vitormattos

Copy link
Copy Markdown
Member

Summary

Remove all 11 deprecated @nextcloud/vue prop usages detected by the Nextcloud ESLint rule on main.

  • Remove close-button-contained from two NcModal instances. Both already set close-button-outside.
  • Use model-value instead of value on the signing-order NcActionInput.
  • Replace close-on-select="false" with keep-open for the three multi-select controls, preserving their behavior.
  • Remove redundant can-close="true" on four NcDialog instances and replace can-close="!isRemovingRule" with no-close="isRemovingRule".
  • Re-enable the recommended @nextcloud/no-deprecated-library-props ESLint rule. New deprecated component props will now fail lint/CI.

This is a targeted Nextcloud 36 / @nextcloud/vue migration. The OCA.Viewer migration is already complete on main (PR #9104); this PR does not change the Viewer or stable branches.

Validation

  • Reproduced 11 deprecated-prop ESLint errors before the change.
  • npx vitest run (the five affected component spec files): 230 tests passed.
  • npm run ts:check: passed.
  • npm run build: passed.
  • npm run lint: passed with 0 errors, including 0 deprecated-prop errors. 21 pre-existing unrelated warnings remain.
  • Verified the deprecated-prop ESLint rule has severity error after removing its exception.
  • Full browser E2E suite: not executed locally (CI will validate).

Only component props and the ESLint override were changed. No dependency updates or generated output.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
vitormattos requested a review from a team as a code owner October 21, 2026 00:25
@vitormattos vitormattos added this to the Next Major (36) milestone Oct 21, 2026
@vitormattos
vitormattos merged commit eea006e into main Oct 21, 2026
66 checks passed
@vitormattos
vitormattos deleted the fix/nc36-deprecated-vue-props branch October 21, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant