Repository navigation
fix(nc36): replace deprecated Nextcloud Vue props - #9137
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove all 11 deprecated
@nextcloud/vueprop usages detected by the Nextcloud ESLint rule onmain.close-button-containedfrom twoNcModalinstances. Both already setclose-button-outside.model-valueinstead ofvalueon the signing-orderNcActionInput.close-on-select="false"withkeep-openfor the three multi-select controls, preserving their behavior.can-close="true"on fourNcDialoginstances and replacecan-close="!isRemovingRule"withno-close="isRemovingRule".@nextcloud/no-deprecated-library-propsESLint rule. New deprecated component props will now fail lint/CI.This is a targeted Nextcloud 36 /
@nextcloud/vuemigration. TheOCA.Viewermigration is already complete onmain(PR #9104); this PR does not change the Viewer or stable branches.Validation
npx vitest run(the five affected component spec files): 230 tests passed.npm run ts:check: passed.npm run build: passed.npm run lint: passed with 0 errors, including 0 deprecated-prop errors. 21 pre-existing unrelated warnings remain.errorafter removing its exception.Only component props and the ESLint override were changed. No dependency updates or generated output.