Skip to content

fix(nc36): replace deprecated Nextcloud Vue props #9137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 2 commits into from
Oct 21, 2026
Merged

fix(nc36): replace deprecated Nextcloud Vue props #9137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f283a89
fix(frontend): replace deprecated Nextcloud Vue props
vitormattos Oct 21, 2026
5293783
chore(lint): enforce supported Nextcloud Vue component props
vitormattos Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ export default [
'@nextcloud/l10n-non-breaking-space': 'off', // ~6 hits; changes translation strings

// Behavior/API risk — may rename Vue events, slots, attrs, or break DOM contracts
'@nextcloud/no-deprecated-library-props': 'off', // ~10 hits; needs careful Nc* prop migration
'vue/attribute-hyphenation': 'off', // ~404 hits; large + DOM attr naming
'vue/custom-event-name-casing': 'off', // ~65 hits; may rename Vue events
'vue/slot-name-casing': 'off', // ~3 hits; may rename slots
Expand Down
1 change: 0 additions & 1 deletion src/components/Request/VisibleElements.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<template>
<NcModal v-if="modal"
:name="signaturePositionsModalTitle"
:close-button-contained="false"
:close-button-outside="true"
size="full"
@close="closeModal">
Expand Down
3 changes: 1 addition & 2 deletions src/components/RightSidebar/RequestSignatureTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
<NcActionInput v-if="canEditSigningOrder(signer)"
:label="t('libresign', 'Signing order')"
type="number"
:value="signer.signingOrder || 1"
:model-value="signer.signingOrder || 1"
@update:modelValue="updateSigningOrder(signer, $event)"
@submit="confirmSigningOrder(signer); closeActions()"
@blur="confirmSigningOrder(signer)">
Expand Down Expand Up @@ -281,7 +281,6 @@
<NcModal v-if="modalSrc"
size="full"
:name="fileName"
:close-button-contained="false"
:close-button-outside="true"
@close="closeModal()">
<iframe :src="modalSrc" class="iframe" />
Expand Down
2 changes: 1 addition & 1 deletion src/views/Settings/AllowedGroups.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
label="displayname"
:no-wrap="false"
:aria-label-combobox="allowedGroupsAriaLabel"
:close-on-select="false"
keep-open
:disabled="loadingGroups"
:loading="isSearching"
:multiple="true"
Expand Down
6 changes: 1 addition & 5 deletions src/views/Settings/PolicyWorkbench/Catalog/Catalog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
v-if="state.activeDefinition"
:name="state.activeDefinition.title"
size="full"
:can-close="true"
@closing="requestCloseSetting()">
<CatalogSettingDialogFrame
:dialog-description="dialogDescription"
Expand Down Expand Up @@ -148,7 +147,6 @@
v-if="showSettingDialogExtrasModal && settingDialogExtrasModal"
:name="settingDialogExtrasModalName"
size="normal"
:can-close="true"
@closing="closeSettingDialogExtrasModal">
<div data-cy="geoip-database-form">
<component
Expand All @@ -164,7 +162,6 @@
:size="ruleEditorDialogSize"
:class="ruleEditorDialogClass"
:buttons="ruleDialogButtons"
:can-close="true"
@closing="requestCloseRuleDialog()">
<div
v-if="state.editorDraft"
Expand Down Expand Up @@ -214,7 +211,6 @@
:message="discardUnsavedChangesDialogMessage"
:buttons="discardDialogButtons"
size="normal"
:can-close="true"
@closing="cancelDiscardDialog" />

<NcDialog
Expand All @@ -223,7 +219,7 @@
:message="pendingRemovalMessage"
:buttons="removalDialogButtons"
size="normal"
:can-close="!isRemovingRule"
:no-close="isRemovingRule"
@closing="cancelRuleRemoval" />
</NcSettingsSection>
</template>
Expand Down
4 changes: 2 additions & 2 deletions ...ews/Settings/PolicyWorkbench/settings/request-sign-groups/RequestSignGroupsRuleEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
label="displayname"
:no-wrap="false"
:aria-label-combobox="authorizedRequesterGroupsAriaLabel"
:close-on-select="false"
keep-open
:disabled="loadingGroups"
:loading="isSearching"
:multiple="true"
Expand All @@ -50,7 +50,7 @@
label="displayname"
:no-wrap="false"
:aria-label-combobox="deniedRequesterGroupsAriaLabel"
:close-on-select="false"
keep-open
:disabled="loadingGroups"
:loading="isSearching"
:multiple="true"
Expand Down
Loading