sd: support for CLIP and VAE on different devices#2184
Open
wbruna wants to merge 3 commits intoLostRuins:concedo_experimentalfrom
Open
sd: support for CLIP and VAE on different devices#2184wbruna wants to merge 3 commits intoLostRuins:concedo_experimentalfrom
wbruna wants to merge 3 commits intoLostRuins:concedo_experimentalfrom
Conversation
wbruna
force-pushed
the
kcpp_sd_multi_device_backend
branch
from
e1210e2 to
1517922
Compare
wbruna
force-pushed
the
kcpp_sd_multi_device_backend
branch
from
1517922 to
197cc2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for placing CLIP or VAE on separate devices (e.g. diffusion on Vulkan0, VAE on Vulkan1). It also enables keeping the diffusion model itself on CPU.
The first two commits adapt the C++ code: the interface receives device numbers instead of booleans, with -1 for "main device" and -2 for "CPU", and the backend includes a global config to choose which model gets which device. The last commit changes the
sdclipgpuandsdvaecpuboolean parameters to accept "CPU", "main" or a device number.Tested on Vulkan with my GPU and iGPU. Seems to work fine with command-line and config settings; however, I wasn't able to fully test the launcher, because there doesn't seem to be a way to select a discrete GPU and an iGPU through it (so I likely got its 1-based indexes wrong).