Skip to content

Await the peer step beside announce so a build without peer has no empty async fn - #174

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
fix/client-announce-without-peer
Oct 18, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
fix/client-announce-without-peer

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Owner

announce, split out in #161, awaits only the peer step, which sits behind the peer feature. A build with device-identity and without peer therefore has an async fn with no .await, and clippy rejects it with unused_async. CI lints only with --all-features, so it never builds that combination.

announce is now a plain function, and its one caller awaits the peer step right after it, in the same order as before.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LucaCappelletti94/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 574c2037-5fa0-4707-9565-7a465e4078d3
📥 Commits

Reviewing files that changed from the base of the PR and between 026f852 and e21cacb.

📒 Files selected for processing: 1
  • crates/connetto-client/src/enrolment/task.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.81%. Comparing base (026f852) to head (e21cacb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   85.07%   87.81%   +2.74%     
==========================================
  Files         188      188              
  Lines       50326    50326              
  Branches    50326    50326              
==========================================
+ Hits        42813    44193    +1380     
+ Misses       5414     4047    -1367     
+ Partials     2099     2086      -13     
Flag Coverage Δ
client 60.52% <100.00%> (-0.04%) ⬇️
rest 55.64% <ø> (+0.01%) ⬆️
server 51.82% <0.00%> (+4.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

@LucaCappelletti94
LucaCappelletti94 merged commit f69caa1 into main Oct 18, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant