Skip to content

Await the peer step beside announce so a build without peer has no empty async fn #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucaCappelletti94 merged 1 commit into from
Oct 18, 2026
Merged

Await the peer step beside announce so a build without peer has no empty async fn #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crates/connetto-client/src/enrolment/task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,9 @@ impl<L: Link> Run<L> {
self.take_lists(lists).await;
// A list naming the new certificate has already revoked or withdrawn it.
if self.held.is_some() {
self.announce(standing).await;
self.announce(standing);
#[cfg(feature = "peer")]
self.peer_transition(standing).await;
}
Ok(())
}
Expand Down Expand Up @@ -946,9 +948,9 @@ impl<L: Link> Run<L> {
Ok(standing)
}

/// Publish the certificate just kept, check its window and start the peer
/// link (lifecycle row "Grant received").
async fn announce(&mut self, standing: Standing) {
/// Publish the certificate just kept and check its window (lifecycle row
/// "Grant received").
fn announce(&mut self, standing: Standing) {
self.publish();
// The server just issued it, so a window that does not hold it now
// says the local clock is off.
Expand All @@ -957,8 +959,6 @@ impl<L: Link> Run<L> {
Standing::Expired => self.clock_outside(true),
_ => self.enroller.clock_off.store(false, Ordering::Release),
}
#[cfg(feature = "peer")]
self.peer_transition(standing).await;
}

/// Delete a certificate whose issuer the root revoked, keep the key, and
Expand Down
Loading