Remove the unreachable insights cluster and the retired comparison toggle - #799
Merged
Conversation
The production dead-code check has been documented rather than enforced since PR #691, because its list mixed real debt with false positives. Triaged against the shipped tree, six of them are genuinely unreachable and go now. Five died when their host was retired and the leaves were left behind: the recommendation card with its confidence meter and feedback control, the grid that mounted them, and the suggested-prompts chip strip that left the hero band in v1.18.7. The sixth, the comparison toggle, has had two regression tests pinning its absence since v1.4.22, because the preference it once set is a Settings concern now. Deleting them freed sixteen translation keys in every locale, a pinned entry in the success-affordance register, and two entries in the Coach gate fixtures. Each of those was found by a guard rather than by reading, which is the point of having them. The adapter under signals/adapters stays: knip reports it as unreachable because only a test imports it, but that test is the registry invariant it exists to prove, and deleting it would remove a check rather than dead weight.
The schemas stay: the insight result still parses recommendations through them. Only the exported aliases went unused once the card that consumed them was removed, and the dead-code gate says so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance, no user-visible change. Six modules that no shipped surface can reach are deleted: the recommendation card chain (card, confidence meter, feedback control, grid), the suggested-prompts strip unmounted in v1.18.7, and the comparison toggle whose absence two regression tests have pinned since v1.4.22.
Fallout the guards caught and this branch cleans up: sixteen orphaned translation keys across all six locales, one stale entry in the success-affordance register, and two entries in the Coach gate fixtures.
Deliberately kept: signals/adapters/metric-status.ts. knip flags it because only a test imports it, but that test is the registry invariant the adapter exists to prove; removing it would delete a check, not dead weight.