[roda] Ignore POST params unless required - #1414
Open
p8 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
/benchmark -f roda |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
/benchmark -f roda --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
|
|
MDA2AV
force-pushed
the
roda/GET-params
branch
from
August 31, 2026 10:37
cf93941 to
c0af9c4
Compare
Owner
|
/benchmark -f roda --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
Owner
|
this is one of the frameworks that holds a very odd baseline behavior the "warm up" round overshoots, this is likely due to a defect in the baseline test we have which has been causing swings in results since it was created. Basically baseline is a little bit different from every other test, it has 3 different requests which are distributed across the available connections but these are persistent long lived connections that live for the benchmark duration, of course killed at the end of each run. However.. some frameworks like this one, have likely a very different performance for a CL and a TE:chunked request types, both are exercised here and this seems to cause a "short circuit" where the connections that use CL happen to be "favoured" by the runtime causing a spikes and swings in the results. This issue will be fixed after baseline test rework where we will not use long lived connections anymore for this test and force an homogeneous request type distribution, rotated every x requests |
Contributor
Author
|
Hmm interesting! |
Contributor
Author
|
/benchmark -f roda --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
/benchmark -f roda |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
request.params merges the GET and POST params. If we only need to read the GET params we don't need to parse the body for POST params.
Contributor
Benchmark ResultsFramework:
Full log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request.params merges the GET and POST params.
If we only need to read the GET params we don't need to parse the body for POST params.
used, and profiles the other framework does not run show
n/arather than a delta.