Skip to content

[roda] Ignore POST params unless required #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p8 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[roda] Ignore POST params unless required #1414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions frameworks/roda/app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,22 +54,25 @@ class App < Roda
end

r.is('baseline11') do
total = request.params['a'].to_i + request.params['b'].to_i
params = request.GET
total = params['a'].to_i + params['b'].to_i
if request.post?
total += request.body.read.to_i
end
render_plain total.to_s
end

r.is 'baseline2' do
total = request.params['a'].to_i + request.params['b'].to_i
params = request.GET
total = params['a'].to_i + params['b'].to_i
render_plain total.to_s
end

r.is 'json', Integer do |count|
params = request.GET
dataset = opts[:dataset_items]
r.halt 500, 'No dataset' unless dataset
m = (request.params['m'] || 1).to_i
m = (params['m'] || 1).to_i
items = dataset.slice(0, count).map do |d|
d.merge(total: (d[:price] * d[:quantity] * m))
end
Expand All @@ -84,9 +87,10 @@ class App < Roda
end

r.is 'async-db' do
min_val = (request.params['min'] || 10).to_i
max_val = (request.params['max'] || 50).to_i
limit = (request.params['limit'] || 50).to_i.clamp(1, 50)
params = request.GET
min_val = (params['min'] || 10).to_i
max_val = (params['max'] || 50).to_i
limit = (params['limit'] || 50).to_i.clamp(1, 50)

rows = self.class.get_async_db&.with do |connection|
connection.exec_prepared('select', [min_val, max_val, limit])
Expand All @@ -100,9 +104,10 @@ class App < Roda

r.is 'crud/items' do
r.get do
category = request.params['category'] || 'electronics'
page = (request.params['page'] || 1).to_i
limit = (request.params['limit'] || 10).to_i
params = request.GET
category = params['category'] || 'electronics'
page = (params['page'] || 1).to_i
limit = (params['limit'] || 10).to_i
offset = (page - 1) * limit

rows = self.class.get_async_db&.with do |connection|
Expand Down
Loading