benchmark-pr: stop the results commit from reverting a PR's deletions - #1438
Open
nigrosimone wants to merge 2 commits into
Open
benchmark-pr: stop the results commit from reverting a PR's deletions#1438nigrosimone wants to merge 2 commits into
nigrosimone wants to merge 2 commits into
Conversation
nigrosimone
marked this pull request as ready for review
September 4, 2026 04:16
nigrosimone
requested review from
Kaliumhexacyanoferrat and
MDA2AV
as code owners
September 4, 2026 04:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git checkout origin/main -- site/data/stages main's copy of every file under it, and thecp -rthat puts the PR's files back does not delete, so a file the PR removed is still in the index when the results are committed.That is what happened to #1434: it deleted
site/data/results/fulmine.js-tuned.jsonand the results commitfdd0e63put it back. The board still ranks afulmine.js-tunedrow for an entry that no longer exists, because rows come fromresults/*.jsonand a nameframeworks.jsondoes not carry falls back toemerginginstead of being dropped.The step now reads main's
site/datainto/tmpwithgit archiveand never touches the working tree. The layout is the same onecp -r site/dataproduced, so the comparison step is unchanged. The second commit deletes the file again;data.jsis not committed here because the deploy regenerates it.Fixes #1436.