Skip to content

benchmark-pr: stop the results commit from reverting a PR's deletions #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MDA2AV merged 2 commits into from
Sep 4, 2026
+7 −576
Merged

benchmark-pr: stop the results commit from reverting a PR's deletions #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
281520b
benchmark-pr: read main's site/data into /tmp instead of checking it out
nigrosimone Sep 4, 2026
6ff3c67
fulmine.js: delete the tuned results file the last run put back
nigrosimone Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/benchmark-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,14 @@ jobs:

- name: Fetch main branch data for comparison
run: |
# Save PR's site/data aside, get main's for comparison
cp -r site/data /tmp/pr_site_data
# main's site/data, read into /tmp and never checked out. The checkout this
# replaces staged main's copy of every file under site/data, and copying the
# PR's files back over does not delete, so a file the PR removed stayed in the
# index and rode along in the results commit.
git fetch origin main --depth=1
git checkout origin/main -- site/data/ 2>/dev/null || true
# Keep main's site/data for comparison, restore PR code
cp -r site/data /tmp/main_site_data
cp -r /tmp/pr_site_data/* site/data/
rm -rf /tmp/main_site_data
mkdir -p /tmp/main_site_data
git archive origin/main:site/data | tar -x -C /tmp/main_site_data

# Frameworks run sequentially — each needs the whole machine. A failure
# doesn't stop the loop: the remaining frameworks still run, whatever was
Expand Down
Loading