Repository navigation
feat(bridge): show Changes First details and refresh session records - #76
Conversation
timeleft--
left a comment
There was a problem hiding this comment.
Captain review of this exact head found two material groups against #69/#55. The six required source checks, 65 shipped real Claude Code tests and 91 focused Python tests pass. Three additional synthetic public-pane/action probes with the pinned credential-free Claude Code 2.1.296 fail: missing-schema success is adopted; a null warning is adopted and the engine skips ui.render; row scrolling removes a whole long detail block. This is supported acceptance failure, not CI-only repair or optional polish.
Please repair both groups in this same PR and add targeted public-seam regressions. Retain the already-working grouping, paired report/disposition, evidence links, times, binding, reader error retention, refresh selection and original explanation readAt. Keep the actual current main and run the normal updater/check with this PR title/body before returning the head. No extra scope, new root/PR, force push, or publication is requested.
timeleft--
left a comment
There was a problem hiding this comment.
Reviewed repaired exact head 2f5e5ae. The three independent public-pane probes from review 5480128915 now pass: missing schema and malformed warnings retain the useful view, and long detail remains readable after scrolling. The full temporary synthetic probe run is 76 pass, 0 fail on the pinned 2.1.296 CLI. Those original findings are addressed.
One integration repair remains before merge: current main is fb0e8ef, version 0.9.0, after PR #78 / child #71. This head does not include it, and the repository updater check against that actual base fails with "branch is behind current base; update the branch and rerun the updater". Merge current main into this worker branch, resolve the shared hooks/types/docs/toolchain changes while retaining both delivered slices, and run the repository-local version updater against the actual base. Do not replace the merged Show Me/Retro behavior with the older skeleton or regress its multi-helper calls-report parser.
Complete the integration already required by #71: availability discovery on every Refresh records press, and correct whole-session/selected-item scope, refs/timestamps and repeat suppression through the actual overview/detail pane on terminal and desktop. Preserve both test suites, the repaired reader/scroll behavior, and the #55 allowlist. This keeps the accepted graph unchanged. Re-run the existing validation/tests and protected source checks on the resulting exact head; installed-host acceptance remains #73.
There was a problem hiding this comment.
Current-main integration in exact e50c768 is clean: #71 is preserved, Refresh discovery and actual item/Back scope are covered, the version updater passes against fb0e8ef, and all six protected source checks are green. The original reader/scroll probes also pass (103 tests on pinned 2.1.296).
One minimum-version compatibility defect remains. The plugin and docs advertise 2.1.293, but running the unmodified 100-test mod suite with the actual 2.1.293 CLI gives 54 pass and 46 fail. The overview item Button contains a string plus nested Text; that renderer rejects it with "JSX element needs a label: the label prop, or one string child", causing the entire pane render hook to be skipped whenever a walkthrough exists.
The smallest correction is an explicit string label or one string child for that Button, retaining item title and status. A temporary synthetic probe copy with only that label changed passes all 103 tests on the actual minimum 2.1.293, so a version-range expansion or new rendering architecture is unnecessary. Please author that small fix on this same PR and verify the existing public-pane suite on both the pinned 2.1.296 and advertised 2.1.293. Retain current base/version, all earlier fixes and the allowlist. I missed the minimum check in the first C review; this is a newly verified compatibility finding, not a recurrence of the resolved reader/scroll groups.
Concurrent-base coordination: PR #66 has the next merge slot on the separate Codex track. Immediately before the final version updater and push, fetch actual main and integrate any newly merged base, preserving its shared packaging/docs changes. Use the actual base SHA/version rather than an anticipated one. Do not edit or dispatch its issues. The Captain will provide the verified merge receipt when #66 lands.
Verified merge receipt: PR #66 merged at 2026-10-10T18:13:16Z. Actual main is now 931e19f, version 0.10.0. Integrate this actual base before the final updater/push, preserve both the merged Codex optional actions and Claude #78 behavior, then verify the repaired pane on the advertised minimum 2.1.293 and the CI pin 2.1.296.
timeleft--
left a comment
There was a problem hiding this comment.
The compatibility fix in exact 0b57f48 is verified: the unmodified shipped mod suite now passes all 100 tests on the actual advertised minimum Claude Code 2.1.293. The single-string item label preserves title and status. Earlier integration, reader and scrolling evidence still applies; no further functional defect is identified.
Only the final shared-base maintenance remains. PR #66 merged after this repair finished, making actual main 931e19f, version 0.10.0. The repository version check against that actual base correctly reports "branch is behind current base; update the branch and rerun the updater". Merge actual main into this same worker branch, preserve its shared manifests and Codex optional actions alongside the Claude slices, and run the repository-local updater against it. Keep the appropriate #69 changelog entry distinct from the newly merged #66 version entry.
The first officers have reserved the next merge slot for PR #76 and are holding further main merges during this short reconciliation. Re-run current-base version policy and existing source CI on the final head; retain the verified minimum-293 compatibility fix and tests. No new feature, parser or rendering repair is requested. This is a concurrent-base move, not a recurrence of the resolved functional findings.
timeleft--
left a comment
There was a problem hiding this comment.
Reviewed exact final head 8e08fd9 against #69 and #55, including integration with #71. All material findings are fixed: malformed reader summaries retain the useful view, long detail/supporting text remains reachable, the minimum-build Button label is supported, Refresh rediscovers commands, and actual item/Back navigation supplies correct action scope. The final branch contains actual main 931e19f and preserves its Codex changes unchanged.
Validation: 103 real pinned-2.1.296 mod tests pass (100 shipped plus three independent synthetic pane probes), 35 focused Python packaging/toolchain tests pass, and the updater check passes for 0.10.0 to 0.11.0. The unmodified 100-test suite passed on the actual minimum 2.1.293 at 0b57f48; the Claude hooks/types/toolchain are identical in this final reconciliation, so that evidence remains valid. All six protected source checks are green on this exact head and all review threads are resolved. No further material defect or unmet slice acceptance remains. Dependent #70 supplies Update explanation; installed-host acceptance stays #73.
Closes #69. Part of #55.
Captain's Bridge reads this exact Claude Code session and presents the Changes First overview, item detail, actor-labelled steps, separate report and disposition, before/after, cited links, elapsed time and collapsed supporting records. Refresh rereads saved records without a model call or message, preserves navigation and the explanation's source time, and reports stale explanations or reader errors while retaining the useful view. Long detail/source text stays reachable when scrolling.
Integrated with #71: Show Me/Retro remain in overview and detail, discovery runs on opening and every Refresh, and actual item/Back navigation supplies title, evidence refs and timestamps. A single-string item label supports the advertised Claude Code minimum 2.1.293. The mod remains within #55's read-only calls allowlist. Version 0.11.0 is synchronized through the repository updater against main 931e19f, preserving the separate Codex track.
Validation: 100 shipped mod tests pass with pinned 2.1.296; three additional Captain synthetic pane probes pass (103 total). The same Claude implementation passes all 100 tests on minimum 2.1.293. Thirty-five focused Python packaging/toolchain tests and current-base version policy pass; all six protected source checks are green. Update explanation is dependent #70; installed-host acceptance is human-only #73.