Repository navigation
refactor(app): replace react-helmet-async with React 19 native metadata - #12420
google-labs-jules[bot] wants to merge 3 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🟡 Changes recommended
An active moderate issue remains because the existing filter-state title update overwrites the new /plots route title, and the current test does not exercise the real hook path.
1 open issue
What changed in this PR
This pull request replaces react-helmet-async with React 19 native document metadata across the application, removing the provider and dependency while preserving route-specific titles, descriptions, canonical links, Open Graph tags, robots metadata, and structured data.
Changes:
- Replaces Helmet wrappers with native JSX metadata across route pages.
- Removes
HelmetProvider, thereact-helmet-asyncdependency, and obsolete test mocks. - Updates affected tests, the Yarn lockfile, and changelog.
- Two moderate issues remain: static shell metadata can duplicate route metadata, and the
/plotstitle is overwritten by the existinguseUrlSynceffect.
| File | Description |
|---|---|
changelog.d/native-document-metadata.md |
Documents the metadata migration. |
app/yarn.lock |
Removes Helmet and unused transitive dependencies. |
app/src/routes/index.tsx |
Removes HelmetProvider. |
app/src/pages/StatsPage.tsx |
Uses native statistics-page metadata. |
app/src/pages/StatsPage.test.tsx |
Removes the Helmet mock. |
app/src/pages/SpecsListPage.tsx |
Uses native specifications-list metadata. |
app/src/pages/SpecsListPage.test.tsx |
Removes the Helmet mock. |
app/src/pages/SpecPage.tsx |
Uses native spec metadata and structured data. |
app/src/pages/SpecPage.test.tsx |
Removes the Helmet mock. |
app/src/pages/PlotsPage.tsx |
Uses native plots-page metadata. |
app/src/pages/PlotsPage.test.tsx |
Updates metadata assertions and removes the Helmet mock. |
app/src/pages/PalettePage.tsx |
Uses native palette-page metadata. |
app/src/pages/NotFoundPage.tsx |
Uses native not-found metadata. |
app/src/pages/NotFoundPage.test.tsx |
Removes the Helmet mock. |
app/src/pages/McpPage.tsx |
Uses native MCP-page metadata. |
app/src/pages/McpPage.test.tsx |
Removes the Helmet mock. |
app/src/pages/MapPage.tsx |
Uses native map-page metadata. |
app/src/pages/MapPage.test.tsx |
Removes the Helmet mock. |
app/src/pages/LibrariesPage.tsx |
Uses native libraries-page metadata. |
app/src/pages/LibrariesPage.test.tsx |
Removes the Helmet mock and unused type import. |
app/src/pages/LegalPage.tsx |
Uses native legal-page metadata. |
app/src/pages/LegalPage.test.tsx |
Removes the Helmet mock. |
app/src/pages/LandingPage.tsx |
Uses native landing-page metadata. |
app/src/pages/LandingPage.test.tsx |
Removes the Helmet mock. |
app/src/pages/AgentChatPage.tsx |
Uses native agent-chat metadata. |
app/src/pages/AgentChatPage.test.tsx |
Removes the Helmet mock. |
app/src/pages/AgentChatPage.save.test.tsx |
Removes the Helmet mock. |
app/src/pages/AgentChatPage.language.test.tsx |
Removes the Helmet mock. |
app/src/pages/AgentChatPage.feedback.test.tsx |
Removes the Helmet mock. |
app/src/pages/AboutPage.tsx |
Uses native about-page metadata. |
app/src/components/RouteErrorBoundary.test.tsx |
Removes the obsolete Helmet mock. |
app/package.json |
Removes the react-helmet-async dependency. |
This pull request requires changes.
Review effort: Lite
| /> | ||
| <link rel="canonical" href="https://anyplot.ai/plots" /> | ||
| </Helmet> | ||
| <title>plots | anyplot.ai</title> |
|
Closing in favour of #12424, which carries the same migration from the Flash run of this Jules task with every check green and the declarative |
Understood. Acknowledging that this work is obsolete and stopping work on this task. |
## Summary - In the `jules-task` skill, a losing or duplicate Jules PR is now closed only after its session was told to stop and has settled. Closing a PR wakes its session: on 2026-10-29 the Gemini 3 Pro session of the closed #12420 pushed a new commit and recreated its deleted branch. ## Plan N/A ## Test plan - [x] `uv run python -m tools.changelog check --base origin/main` - [x] Docs-only diff under 20 lines: no Flash check (CLAUDE.md, delegation rule) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#12449) ## Summary - `test_local_backend_kills_the_container_on_cancellation` waited at most 10 s for both fake theme containers and then cancelled anyway. On a loaded CI runner that produced a misleading assertion (`['r-cancelme-light'] == ['r-cancelme-dark', 'r-cancelme-light']`, seen once on #12420). The wait is now 25 s (the fake containers live 30 s), and a timeout raises a clear `RuntimeError` instead of falling through. - Written by Google Jules on `feature/deterministic-cancel-test` (#12447). Its description says the root cause was the silent timeout; the race could not be reproduced locally, so this PR claims a clearer and more tolerant test, not a proven fix. `agents/anyplot/render/backends/local.py` is unchanged (the parallel R-pilot session asked for that). ## Plan N/A ## Test plan - [x] `uv run pytest tests/unit/agents/runtime/test_render.py`: passes - [x] `ruff check` - [x] Diff under 20 lines: no Flash pre-PR check (CLAUDE.md delegation rule) --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Per-route page metadata uses React 19 native hoisting. Pages render bare
<title>,<meta>and<link rel="canonical">elements instead of wrapping them inreact-helmet-async, which is archived upstream; the dependency and itsHelmetProviderare gone.Closes #9629
PR created automatically by Jules for task 14601851301358581634 started by @MarkusNeusinger