Repository navigation
fix(eid-wallet): translate the apps ribbon categories the marketplace uses - #1188
Merged
Merged
Conversation
… uses The ribbon only translated Social, Governance and Finance, so the live categories (Productivity, Wellness, Communication, Other) stayed in English in ru and uk. Add labels for those and for Identity and Storage, the other categories the marketplace lists.
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughMarketplace translations were added for additional categories in English, Russian, and Ukrainian. The eID Wallet marketplace category mapping now includes labels for communication, identity, other, productivity, storage, and wellness. ChangesMarketplace localization
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The added marketplace categories resolve to localized labels in English, Russian, and Ukrainian. No merge-blocking issue was identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sahil2004
approved these changes
Oct 3, 2026
4 tasks done
Sahil2004
pushed a commit
that referenced
this pull request
Oct 5, 2026
The apps ribbon now loads from the marketplace's live platforms (#1181), a new user-facing capability, so this is a minor rather than a patch. #1188 follows with the category translations. The Android versionCode goes to 33, continuing 24, 25, 26, 27, 28, 31, 32. .env.example gains the docs site as a commented value for PUBLIC_TRANSLATIONS_URL, the way it already offers the registry and provisioner URLs per environment. Empty disables the runtime correction catalog, which suits a local checkout but leaves a release build unable to receive wording fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The apps ribbon showed most categories in English after switching the wallet to Russian or Ukrainian. Only Social, Governance and Finance had translations, while the live platforms mostly use Productivity, Wellness, Communication and Other. This adds labels for those, plus Identity and Storage from the marketplace's own category list.
Issue Number
Closes #1184
Type of change
How the change has been tested
/api/platformstoday returns Productivity (11), Wellness (2), Communication, Other and Social. All five now have labels.docs/static/translations.jsonregenerated withbuild-translations-catalog.mjs;--checkreports it up to date.marketplaceApps.spec.tspasses (22/22).svelte-checkreports one error,Cannot find module '@tauri-apps/plugin-http', because that package from feat(eid-wallet): load the apps ribbon from the marketplace's live platforms #1181 isn't installed locally. It is unrelated to this change.Change checklist
Summary by CodeRabbit