Repository navigation
Delete the store package - #449
Merged
Merged
Conversation
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the
storepackage and guards the layering. This finishes issue #1.services/core/internal/storehad no production code left. Its 243 integration test files move withgit mvtoservices/core/tests/integration(packageintegration). The changes stay mechanical: theexport_test.goforwarders are gone, and three files are renamed. The set of top-level test names is the same before and after (411), and the 3 shards still split them exactly once.runtimehistory/postgresreadermoves topersistence/postgres/runtimehistorypg, beside the other adapters.cmd/server/layering_test.gouses only the standard library and runs inbackend (core). Outsideinternal/persistenceandinternal/db, it rejects any non-test file that imports a persistence package, the generated queries or pgx. The rule is stated once inservices/core/IMPLEMENTATION.md.check-core-storetarget becomescheck-core-integration, withCORE_INTEGRATION_PACKAGEandOAC_CORE_INTEGRATION_SHARD.check.ymlmatrix part is nowintegration, still in 3 shards. The required check is stillcheck.api-acceptance.ymlpath changes, and two test names that no longer exist are dropped from its-runpattern.ci_plan_test.pyandci_shard_test.pysamples are updated.development.md,maintainers.md,harness-onboarding.md,model-execution.md, plusservices/core/README.md.verifyEnvironmentEventsWithSDKandtests/official_environment_events.py.Blind review found no blockers or majors. The minors and nits are fixed. Folding
fixtureDBinto the integrationStorefixture is left for a follow-up.Checks:
go build ./...,go vet ./services/core/..., andgo test ./services/core/cmd/server(includingTestLayering).apiandexecutiontests.check-names,ci_plan_test,ci_shard_test, and the website translations test.make openapiproduces no diff.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.