Skip to content

ci: allow ubuntu-26.04 runner label in actionlint - #790

Closed
DerekRoberts wants to merge 3 commits into
mainfrom
ci/actionlint-runner-labels
Closed

DerekRoberts wants to merge 3 commits into
mainfrom
ci/actionlint-runner-labels

Conversation

@DerekRoberts

@DerekRoberts DerekRoberts commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

actionlint 1.7.12 does not know the GitHub-hosted ubuntu-26.04 label yet, so Lint Workflows fails on the runner bump in #789.

Adds .github/actionlint.yaml listing the label, matching bcgov/nr-forest-client-commons#337. Refs #789

Summary by CodeRabbit

  • Chores
    • Added configuration for recognizing the ubuntu-26.04 self-hosted runner label in workflow validation.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: d6f452d7-ca5f-4e9a-ad2e-c8811991af35
📥 Commits

Reviewing files that changed from the base of the PR and between b2b273a and 0802de8.

📒 Files selected for processing: 1
  • .github/actionlint.yaml

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The actionlint configuration adds ubuntu-26.04 as a self-hosted runner label and documents the related workaround.

Changes: Actionlint Configuration

Layer / File(s) Summary
Declare runner label
.github/actionlint.yaml
The configuration adds ubuntu-26.04 under self-hosted-runner and documents the workaround.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 0802d

The configuration-only change has no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: allowing the ubuntu-26.04 runner label in actionlint configuration.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@DerekRoberts
DerekRoberts marked this pull request as ready for review October 20, 2026 22:30
Copilot AI balanced review requested due to automatic review settings October 20, 2026 22:30
@DerekRoberts DerekRoberts moved this from New to Active in Dev Oct 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

The configuration is narrowly scoped, matches the existing actionlint setup, and has no identified blocking issues.

No open issues 🎉

What changed in this PR

Adds an actionlint configuration workaround so workflow linting accepts the Ubuntu runner label introduced by #789.

Changes:

  • Allows ubuntu-26.04 without changing workflow execution.
File Description
.github/​actionlint.yaml Adds ubuntu-26.04 to actionlint’s accepted runner labels.

Review effort: Balanced

Comment thread .github/actionlint.yaml Outdated
@kilo-code-bot

kilo-code-bot Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Code Review Roast 🔥

Verdict: No Issues Found | Recommendation: Merge

Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything.

The previous nitpick — that the comment pawned a GitHub-hosted label off as a self-hosted one — is resolved. Line 2 now says the quiet part out loud: self-hosted-runner is just actionlint's catch-all bin for labels it hasn't learned yet. The key is unchanged, ubuntu-26.04 still sits where it belongs, and the follow-up commit did exactly one thing: reword one comment. No scope creep, no reformatting the .github/ tree, no mystery TODO smuggled in as a "clarification."

📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are. Note the merge of main is already the PR base, so nothing extra sneaks into this diff; the whole change is still that one comment.

Files Reviewed (1 file)
  • .github/actionlint.yaml
Previous Review Summary (commit b2b273a)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit b2b273a)

Verdict: 1 Issue Found | Recommendation: Optional cleanup, then merge

Overview

Severity Count
🚨 critical 0
⚠️ warning 0
💡 suggestion 0
🤏 nitpick 1
Issue Details (click to expand)
File Line Roast
.github/actionlint.yaml 2 The key is named self-hosted-runner and it's holding a GitHub-hosted label. Functionally correct (it's actionlint's documented catch-all), but the comment sells a slightly wrong mental model.

🏆 Best part: Four lines, one job, zero scope creep. No # TODO, no commented-out alternatives, no reformatting the whole .github/ tree to sneak in a label. I had my flamethrower idling for nothing on the YAML itself.

💀 Worst part: The only thing on fire is a comment. Placing ubuntu-26.04 under self-hosted-runner.labels is the correct actionlint workaround, so the config does what it says — but the comment describes these as self-hosted-adjacent when it's really "labels actionlint hasn't learned yet." It's a documentation nit, and I'm aware I'm reaching for kindling here.

📊 Overall: Like a single-screw IKEA fix — small, correct, and the only complaint is that the label on the drawer is slightly misleading. Also note: this config only silences the linter; it can't make ubuntu-26.04 a real GitHub-hosted runner, so make sure #789's bump is actually schedulable before relying on it.

Files Reviewed (1 file)
  • .github/actionlint.yaml - 1 nitpick

Fix these issues in Kilo Cloud


Reviewed by efficient · Input: 36.9K · Output: 6.6K · Cached: 227.3K

@DerekRoberts DerekRoberts added the duplicate This issue or pull request already exists label Oct 21, 2026
@github-project-automation github-project-automation Bot moved this from Active to Done in Dev Oct 21, 2026
@DerekRoberts
DerekRoberts deleted the ci/actionlint-runner-labels branch October 21, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants