Repository navigation
ci: allow ubuntu-26.04 runner label in actionlint - #790
DerekRoberts wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
🟢 Approved
The configuration is narrowly scoped, matches the existing actionlint setup, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
Adds an actionlint configuration workaround so workflow linting accepts the Ubuntu runner label introduced by #789.
Changes:
- Allows
ubuntu-26.04without changing workflow execution.
| File | Description |
|---|---|
.github/actionlint.yaml |
Adds ubuntu-26.04 to actionlint’s accepted runner labels. |
Review effort: Balanced
Code Review Roast 🔥Verdict: No Issues Found | Recommendation: Merge Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything. The previous nitpick — that the comment pawned a GitHub-hosted label off as a self-hosted one — is resolved. Line 2 now says the quiet part out loud: 📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are. Note the merge of Files Reviewed (1 file)
Previous Review Summary (commit b2b273a)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit b2b273a)Verdict: 1 Issue Found | Recommendation: Optional cleanup, then merge Overview
Issue Details (click to expand)
🏆 Best part: Four lines, one job, zero scope creep. No 💀 Worst part: The only thing on fire is a comment. Placing 📊 Overall: Like a single-screw IKEA fix — small, correct, and the only complaint is that the label on the drawer is slightly misleading. Also note: this config only silences the linter; it can't make Files Reviewed (1 file)
Reviewed by efficient · Input: 36.9K · Output: 6.6K · Cached: 227.3K |
actionlint 1.7.12 does not know the GitHub-hosted
ubuntu-26.04label yet, so Lint Workflows fails on the runner bump in #789.Adds
.github/actionlint.yamllisting the label, matching bcgov/nr-forest-client-commons#337. Refs #789Summary by CodeRabbit
ubuntu-26.04self-hosted runner label in workflow validation.