Repository navigation
Parallel state flow - #1
Merged
Merged
Conversation
xiangzhi
reviewed
Nov 20, 2025
| for child in self._children: | ||
| # because each child starts their own thread, no extra management required. | ||
| child.start(board) | ||
| child.start(board, flow_in=self.flow_in) |
There was a problem hiding this comment.
Can you change this to use a deepcopy? I think there is a possibility that it is a dict or other object, and someone might change it and cause issues for other child nodes?
There was a problem hiding this comment.
Can you also add a test to showcase this?
xiangzhi
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added flow in and out for parallel states.
Flow in to the parallel state is propagated to all children such that they each receive an identical copy of the flow in to the parallel state.
Flow out from the parallel state is in the form of a list where each child's flow out is appended in the order that the children are stored in the parallel state.
Added testing for both flow in and out.