Repository navigation
Add the Image with Text homepage section - #68
Merged
Merged
Conversation
A 50/50 image and copy split (partials/section_image_text.html) with image left/right, square/portrait/landscape/native image ratio, eyebrow, heading, rich-text body, a CTA with primary/secondary/outline styles, and background and text colours. On mobile it stacks image first. It is included from templates/index.html between Featured Categories and On Sale, behind the show_image_text toggle, which is off by default so existing stores render unchanged. With the toggle on and nothing configured it renders the same setup placeholder pattern as the sibling sections, with a localized pointer to the settings location added to every locale file. partials/cta_button.html gains a `secondary` style so the section can reuse the existing .btn-secondary class through the shared helper. image_text_cta_text follows the localization contract: no schema default, omitted from settings data, the template applies the localized fallback. assets/main.css is rebuilt for the new ratio and ordering utilities (50298 -> 50536 bytes); css/input.css is unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Add docs/section-specs/image-text.md in the existing spec format (render contract, setting map, Figma states, QA checklist, migration table, gaps), list it in the section-specs index, the roster's Tier 0 table and shipped counts, the Figma plan's section-unit table, the architecture proposal's migration list, and the settings-to-partials catalog. Update the homepage section enumerations in CLAUDE.md and README.md, note the new `secondary` CTA style in the design-block guide, and add the Unreleased changelog entry. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…gument settings.* as a filter argument raises a 500 on the platform once the setting is populated; firstof yields the same string safely. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
next-devin
marked this pull request as ready for review
September 21, 2026 08:30
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The previous review's heading-color fix at Files Reviewed (PR #68 diff hunks since 88f969e)
Previous Review Summaries (3 snapshots, latest commit 88f969e)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 88f969e)Status: No Issues Found | Recommendation: Merge Overview
Commit
Files Reviewed (2 changed files)
Previous review (commit 4029e00)Status: 0 New Issues Found | Recommendation: Merge Overview
Commit
Follow-up (summary-only, not on a diff line)
Files Reviewed (5 changed files)
Fix these issues in Kilo Cloud Previous review (commit e0f8d24)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (26 files)
Reviewed by minimax-m3 · Input: 0 · Output: 0 · Cached: 0 |
Review follow-ups on #68: the live guard needs a heading or body, so an image alone renders the setup placeholder instead of a lone image beside an empty column; the outline CTA branch drops a redundant style kwarg; the spec records the |safe trust on the richtext setting; the placeholder caption is translated in the locales that translate their siblings. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The base stylesheet and the global heading colour setting give every heading an explicit colour, so dropping text-slate-800 left the h2 dark on a dark custom background. Apply the section colour inline on the heading. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Sep 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice of #30: the
image_textsection. FAQ, testimonials and rich text wait on section specs and stay open on the issue.What changed
partials/section_image_text.html: 50/50 image and copy split. Image left or right, ratio square / portrait / landscape / native, eyebrow, heading, richtext body, CTA (primary / secondary / outline), background and text colour. Mobile stacks image first. Toggle off renders nothing; toggle on with no content renders the dashed setup placeholder like the other sections; a missing image with copy present renders a neutral block at the chosen ratio.Homepage > Image with Textgroup and ashow_image_texttoggle (default off, so existing stores are unchanged). Setting names follow the roster entry verbatim, plusimage_text_image_alt.settings_data.json,settings_optional.txt, the localization contract test and all 11 locale files (one placeholder key) are updated.templates/index.htmlbetween Featured Categories and On Sale, so the story block breaks up the two product grids. Easy to move.partials/cta_button.htmlgains asecondarystyle mapping to the existing.btn-secondary.docs/section-specs/image-text.mdin the existing spec format; roster, plan, architecture proposal, theme-settings, design-block guide,CLAUDE.md,README.mdand CHANGELOG updated for seven shipped sections.assets/main.cssrecompiled (new ratio and order utilities);css/input.cssuntouched.Verification
make verify-theme: css-check, 78 tests, theme contract gate (63 templates) passnode tests/js/*.test.js: 12 pass{% firstof %})Reviewer notes
image_text_cta_stylediffers from the older sections'*_cta_style(primary/accent) plus*_cta_outlinecheckbox. This follows the roster; decide which model new sections standardise on.homepage.cta.shop_now. A "Learn more" default would need a new key across 11 locales.image_textto shipped when this merges.🤖 Generated with Claude Code