Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in path resolution - #2

Open
msant262 wants to merge 1 commit into
mainfrom
fix-command-injection-shellpath-6425956979438145569
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in path resolution#2
msant262 wants to merge 1 commit into
mainfrom
fix-command-injection-shellpath-6425956979438145569

Conversation

@msant262

@msant262 msant262 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in path resolution

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The shellPath function in server/hermesCollector.js was insecurely concatenating user input to construct paths starting with ~. If an attacker provided a path like ~/foo; rm -rf /, the resulting command "$HOME"/foo; rm -rf / would execute arbitrary shell commands due to missing shell quoting.
🎯 Impact: Remote code execution (RCE) on the server executing SSH commands.
πŸ”§ Fix: Used shellQuote to sanitize the portion of the path following ~/ while preserving $HOME interpolation correctly, so ~/foo; rm -rf / becomes "$HOME"'/foo; rm -rf /'.
βœ… Verification: Tested the function logic by verifying output mapping of shellPath('~/foo; rm -rf /') resolves securely to "$HOME"'/foo; rm -rf /'.


PR created automatically by Jules for task 6425956979438145569 started by @msant262

Co-authored-by: msant262 <39443895+msant262@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant