π‘οΈ Sentinel: [CRITICAL] Fix command injection in path resolution - #2
π‘οΈ Sentinel: [CRITICAL] Fix command injection in path resolution#2msant262 wants to merge 1 commit into
Conversation
Co-authored-by: msant262 <39443895+msant262@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘οΈ Sentinel: [CRITICAL] Fix command injection in path resolution
π¨ Severity: CRITICAL
π‘ Vulnerability: The
shellPathfunction inserver/hermesCollector.jswas insecurely concatenating user input to construct paths starting with~. If an attacker provided a path like~/foo; rm -rf /, the resulting command"$HOME"/foo; rm -rf /would execute arbitrary shell commands due to missing shell quoting.π― Impact: Remote code execution (RCE) on the server executing SSH commands.
π§ Fix: Used
shellQuoteto sanitize the portion of the path following~/while preserving$HOMEinterpolation correctly, so~/foo; rm -rf /becomes"$HOME"'/foo; rm -rf /'.β Verification: Tested the function logic by verifying output mapping of
shellPath('~/foo; rm -rf /')resolves securely to"$HOME"'/foo; rm -rf /'.PR created automatically by Jules for task 6425956979438145569 started by @msant262