Repository navigation
docs(openspec): propose keep-parties-after-members-leave - #25
Merged
Merged
Conversation
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
A player invites a friend, and they play together for an hour. The friend's connection drops, or they step away. The
player who stayed sees "the party was disbanded, the last member left". When the friend comes back a few minutes later,
there is no party to rejoin, and the player has to create one again and invite everyone again.
This proposal keeps the party open when it drops to one member. The remaining player stays the party's leader if they
were already, or becomes the leader by the existing succession rule. The party keeps its id and gets the same alone
timeout as a party that nobody ever joined (30 minutes by default), counted from the moment the friend left. If somebody
joins in time, the timer stops. If the party is alone again later, the timer starts again from that moment. A party that
loses its last member is still closed at once.
The remaining player is told that the other one left and that the party closes if nobody joins for a while. The warning
before closing and the closing message stay as they are today. Parties stored by an older backend keep their current
expiry.
The change ships as
fix(party). Code follows once this proposal is merged. The full proposal, design decisions andtasks are in
openspec/changes/keep-parties-after-members-leave/.Types of changes
Checklist
Further comments
Only the OpenSpec proposal is in this pull request; no code. Points for review:
before, so no migration is needed.
the party stays open, and the code change adds that message in English and German.
add-party-lifecycle, whichis not archived yet, so there is no base spec to modify. They become valid once that change is archived.