Repository navigation
fix(libraries): declare DiagramLayout, IdentityMetadata, MigrationMetadata and SysMLValidation as library package - #3
Merged
Conversation
…adata and SysMLValidation as library package Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four libraries were declared
standard library package. That keyword is reserved for the OMG standard library, and the pinned pilot validator warns on it (User library packages should not be marked as standard). They are non-normative extensions, so line 1 of each now reads:The same change applies to
IdentityMetadata,MigrationMetadataandSysMLValidation. No other library bytes change, and the change is identical to the one proposed in Open-MBEE/OpenSysML#882.validation/allowed-warnings.txtis now empty, so CI requires 0 errors and 0 warnings. The ratchet is unchanged: an allow-list entry the validator no longer emits still fails the gate.engine-contract.jsonis unchanged. Package names and members are the same, so this is not a contract change.Local results:
./scripts/validate-libraries.shprintsValidation clean: 0 errors, 0 warning(s).check-engine-contract.shpasses..kparbuild passes (16 units).Merge with a merge commit. Open-MBEE/OpenSysML#881 pins this branch's head while both PRs are open. After this merges, I'll move #881's pin to the merge commit on
main.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/bf0cf4d7769a49a8adfee6bfd87860f3
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/bf0cf4d7769a49a8adfee6bfd87860f3?variant=devin
Requested by: @HuiJun