Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,9 @@ the manifest against the base and fails on unannounced breaking changes.

`./scripts/validate-libraries.sh` runs the pinned OMG pilot batch validator
(`scripts/pilot-pin.sh`) over `libraries/` and requires zero errors and zero
warnings. Four warnings are temporarily allow-listed in
`validation/allowed-warnings.txt` — the four files that still declare
`standard library package`; an upstream change to `library package` is being
ported and those entries will be deleted. The allow-list only shrinks.
warnings. `validation/allowed-warnings.txt` is empty: no warning is
allow-listed, and the ratchet fails on any allow-list entry the validator no
longer emits.

## License

Expand Down
2 changes: 1 addition & 1 deletion libraries/DiagramLayout.sysml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
standard library package DiagramLayout {
library package DiagramLayout {
doc /* Diagram geometry in notation: where a view draws an element, the
* waypoints an edge is drawn through and the extent of the drawing
* surface. Units are pixels, y down, origin at the top left.
Expand Down
2 changes: 1 addition & 1 deletion libraries/IdentityMetadata.sysml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
standard library package IdentityMetadata {
library package IdentityMetadata {
doc /* Binds notation to repository identity. Non-normative OpenSysML
* extension, proposed for standardization; see the design record. */

Expand Down
2 changes: 1 addition & 1 deletion libraries/MigrationMetadata.sysml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
standard library package MigrationMetadata {
library package MigrationMetadata {
doc /* What a migration from another modeling language had to make up
* because its source left it unstated. Non-normative OpenSysML
* extension, proposed for standardization; see the design record. */
Expand Down
2 changes: 1 addition & 1 deletion libraries/SysMLValidation.sysml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
standard library package SysMLValidation {
library package SysMLValidation {
doc
/*
* Validation constraints of the KerML and SysML abstract syntax, stated over
Expand Down
2 changes: 1 addition & 1 deletion scripts/validate-libraries.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,4 @@ if [[ "$fail" -ne 0 ]]; then
fi

count="$(grep -cE '^[^:]+:[0-9]+:[0-9]+: (error|warning): ' <<<"$diagnostics" || true)"
echo "Validation clean: 0 errors, $count allow-listed warning(s)"
echo "Validation clean: 0 errors, $count warning(s)"
10 changes: 2 additions & 8 deletions validation/allowed-warnings.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
# Warnings the pinned OMG pilot validator emits over libraries/ that the gate
# accepts for now, exactly as the validator prints them.
#
# These four files declare `standard library package`; an open
# Open-MBEE/OpenSysML pull request changes them to `library package`. Once it
# merges, the change is ported here and these entries are deleted. This list
# may only shrink: an entry the validator stops emitting fails the gate.
DiagramLayout.sysml:1:1: warning: User library packages should not be marked as standard
IdentityMetadata.sysml:1:1: warning: User library packages should not be marked as standard
MigrationMetadata.sysml:1:1: warning: User library packages should not be marked as standard
SysMLValidation.sysml:1:1: warning: User library packages should not be marked as standard
# Currently empty: no warning is allow-listed. This list may only shrink: an
# entry the validator stops emitting fails the gate.
Loading