Repository navigation
webui: support the HmIP-RFUSB stick as central radio module - #210
Conversation
This applies OpenCCU rootfs patch 0155-WebUI-Add-HmIP-RFUSB-Support.patch: - Treat the HmIP-RFUSB like the HmIP-CCU3 and RPI-RF-MOD radio modules: no channel parameters, the CoPro maintenance control, its channels shown in the device list and its type in the list of device types without user settings (devicetypelist.js). - Add a device description for HmIP-RFUSB with the CCU3 images (config/devdescr/copro_usb_hmip-rfusb.tcl). - Name HmIP-CCU3, RPI-RF-MOD and HmIP-RFUSB "Homematic IP Zentrale" / "Homematic IP Central Control Unit" in the device descriptions.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: WebUI support for the HmIP-RFUSB stick as a central radio module. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4 files. (4 skipped: 4 unsupported.)
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This removes OpenCCU rootfs patch 0155-WebUI-Add-HmIP-RFUSB-Support.patch, now that OpenCCU/OpenCCU-Base#210 is merged.
1 participant
Original OpenCCU rootfs patch: 0155
Original filename:
0155-WebUI-Add-HmIP-RFUSB-Support.patchOriginal patch: ``''
https://github.com/OpenCCU/OpenCCU/blob/687f3c7d336289960db59cfc686aea0ecf9cb0dc/buildroot-external/package/openccu-base/rootfs-patches/0155-WebUI-Add-HmIP-RFUSB-Support.patch''''Original changes: OpenCCU/OpenCCU@6c9cc9f31 (HmIP-RFUSB as Advanced IP Routing gateway)
OpenCCU supports the HmIP-RFUSB stick as the central radio module. The WebUI handles it like the HmIP-CCU3 and RPI-RF-MOD radio modules. This applies the patch:
src/webui/www/config/easymodes/etc/hmipChannelConfigDialogs.tcl: no channel parameters to set forHmIP-RFUSB.src/webui/rega/www/esp/datapointconfigurator.fn: the CoPro maintenance control forHmIP-RFUSBchannels.src/webui/rega/www/esp/functions.fn: show the maintenance channel ofHmIP-RFUSBlike the other radio modules.src/webui/www/tools/js/model/devicetypelist.jsandsrc/webui/www_source/webui/js/model/devicetypelist.js(thewebui.jspart):HmIP-RFUSBin the list of device types without user settings.src/webui/www_source/config/devdescr/copro_usb_hmip-rfusb.tcl(new, theDEV_*part ofwebui.js): device description ofHmIP-RFUSBwith the CCU3 images, a copy ofcopro_rpi-rf-mod.tcl.create_devdescr_js.tclprocesses the files sorted by name; the name is chosen so that the entries followRPI-RF-MODinwebui.jsexactly as in the patch.src/webui/www/webui/js/lang/{de,en}/translate.lang.deviceDescription.js:HmIP-CCU3,RPI-RF-MODand the newHmIP-RFUSBare named "Homematic IP Zentrale" / "Homematic IP Central Control Unit".Line endings, encodings and the missing/added final newlines follow the patch, including the whitespace-only last line of
www/tools/js/model/devicetypelist.js. The rootwww/copies are unused legacy files and are left unchanged.One intended difference:
DEVDB.tclcreate_devdescr_js.tclgenerates bothwebui.js(devdescr.js) andwww/config/devdescr/DEVDB.tclfrom theconfig/devdescr/*.tclfiles. The rootfs patch only edited the generatedwebui.js, so the Tcl device database used byic_deviceparameters.cgi,ic_seldevice.cgi,ic_selchannel.cgiandic_ifacecmd.cgi(DEV_getImagePathetc.) did not knowHmIP-RFUSB. With the native description it now does:DEVDB.tclgainsHmIP-RFUSBinDEV_LIST,DEV_DESCRIPTION,DEV_PATHS(CCU3 images) andDEV_HIGHLIGHT(empty), likeRPI-RF-MOD. All other entries are unchanged (compared by loading both files in Tcl); the textual order of the dumped Tcl arrays differs because of the added key.Validation
functions.fnwith an offset of 2 lines);git diff --check(withcr-at-eol) only reports the whitespace-only last line taken over from the patch.scripts/base-patch-migration.py validatewith the canonical Buildroot 2026.08git4archive of this branch (e0ae1223, sha256a620c9b0d8d9ba569e6d8d32081670cbf50ab5460cca428a62fe6bfbc4b69d9b) and--skip-patch 0155, on OpenCCUmaster687f3c7d3(current pin935847b1, equal tomain): PASS (the other 48 rootfs patches apply with zero fuzz).compareagainst a validation of the current pin935847b1with all 49 patches: 4665 of 4666 entries identical, includingwebui.js; the only difference iswww/config/devdescr/DEVDB.tclas described above.OpenCCU cleanup PR (removing patch 0155 and updating the pin): OpenCCU/OpenCCU#4456
Generated by Claude Code
Summary by CodeRabbit
Generated by Claude Code