Repository navigation
fix(webui): show an error when a control panel popup fails with status 0 - #4453
Merged
Merged
Conversation
Prototype treats HTTP status 0 (e.g. a network error) as success, so the onFailure handler of cpMessageBox.LoadFromFile() added by rootfs patch 0089 is not called and the popup stays open without content. Handle status 0 in onComplete with the same error handling, now shared in showLoadError(). The later workspaces containing this code are updated accordingly; only patch 0089 changes.
jens-maus
added
🏷️ OCCU
Claude
jens-maus
added a commit
to OpenCCU/OpenCCU-Base
that referenced
this pull request
Oct 16, 2026
This applies the fix of OpenCCU/OpenCCU#4453, as found in the review of this PR: - Prototype treats HTTP status 0 (e.g. a network error) as success, so onFailure is not called. Handle status 0 in onComplete with the same error handling, now shared in showLoadError().
This was referenced Oct 16, 2026
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe message-box loader now treats completed requests with status 0 as failures. It shares error handling with request failures, while other completed requests retain the existing display behavior. The patch migration manifest records the updated patch size and SHA-256 value. ChangesMessage-box load failure handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: showing an error when a control panel popup request fails with status 0. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (28 skipped: 2 unsupported, 26 too large.)
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
jens-maus
added a commit
to OpenCCU/OpenCCU-Base
that referenced
this pull request
Oct 16, 2026
* webui: show an error when a control panel popup fails to load This applies OpenCCU rootfs patch 0089-WebUI-MessagBoxFailureWarning.patch: - cpMessageBox.LoadFromFile() gets an onFailure handler. If the control panel page cannot be loaded, it hides the empty popup and its overlay and shows an error message instead of leaving the WebUI blocked. - CreateCPPopup(), cpMessageBox.initialize() and LoadFromFile() accept an optional errorLbl translation key for that message; without it, the common Ajax_failure() message is shown. * webui: show an error when a control panel popup fails with status 0 This applies the fix of OpenCCU/OpenCCU#4453, as found in the review of this PR: - Prototype treats HTTP status 0 (e.g. a network error) as success, so onFailure is not called. Handle status 0 in onComplete with the same error handling, now shared in showLoadError().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rootfs patch
0089-WebUI-MessagBoxFailureWarning.patchadds anonFailurehandler tocpMessageBox.LoadFromFile(), so a control panel popup that fails to load shows an error instead of an empty popup that blocks the WebUI.Prototype treats HTTP status 0 (e.g. a network error or an aborted request) as success (
success()returns!status || 2xx), soonFailureis not called in that case:Ajax.Updaterfills the popup with the empty response and onlyonCompleteruns, leaving the popup open without content.This PR:
onFailureinto a localshowLoadError(statusText)helper,onCompletefortrans.status == 0(and returns before showing the popup),onFailurefor HTTP error status codes.This was found by CodeRabbit in the review of OpenCCU/OpenCCU-Base#205 (native migration of patch 0089) and will be mirrored there once merged.
The workspaces of the later rootfs patches that contain this code in their
webui.js(.origand modified files, 50 files) are updated with the same text replacement. After regenerating, only patch 0089 changes; all other patches are byte-identical.Validation
create_patches.sh --check: clean.base-patch-migration.py index: PASS (50 patches), index updated for patch 0089. The migration unit tests passed.validateagainst the current pinc9553f93: PASS, all 50 patches apply with zero fuzz.masteronly inwww/webui/webui.js, and only inLoadFromFile()as described above;node --checkpasses for the resultingwebui.js.Generated by Claude Code
Summary by CodeRabbit