Repository navigation
PerturbedEquilibrium - BUGFIX! - Reject a perturbed equilibrium solved with a wall - #620
Draft
matt-pharr wants to merge 3 commits into
Draft
matt-pharr wants to merge 3 commits into
matt-pharr wants to merge 3 commits into
Conversation
github-actions
Bot
added
bugfix
Contributor
|
This pull request is missing a reviewer. If you are not ready to name them, mark this pull request as a draft. |
…d with a wall The plasma response P = Λ·L⁻¹ took Λ from the run's δW, with its wall, and the surface inductance L from free space, so a wall run silently mixed two vacuum models. plasma_response now errors on a force-free-states solve with a wall, and parse_deck stops on a deck with both [PerturbedEquilibrium] and [Wall]. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014wKUyAaxKdTJ5ch1boMFE1
… TJ equilibrium The Solovev kink needs a wall at every q0 and elongation scanned, so it cannot run a perturbed equilibrium once a wall is rejected. TJ_ideal_example and the three TJ_kinetic_* decks replace the Solovev PE decks on a TJ-analytic equilibrium stable at n = 1 with no wall (et[1] = +0.435). Solovev_ideal_example keeps its wall and drops its PE stage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ixtures Every test that runs a perturbed equilibrium now starts from a coarse TJ-analytic fixture with no wall. The harness tracks the moved decks as tj_n1 and tj_kinetic_*; solovev_n1 stays as stability only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d-burg
force-pushed
the
bugfix/pe-reject-wall
branch
from
October 31, 2026 23:00
de5d179 to
e375075
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #613
What this does
The plasma response P = Λ·L⁻¹ took Λ from the run's δW, with its wall, and the surface inductance L from free space, so a run with a wall silently mixed two vacuum models. Now:
plasma_responseerrors on a force-free-states solve with a wall;parse_deckstops on a deck with both[PerturbedEquilibrium]and[Wall].Both error messages give the fix: solve without a wall.
Still to do
The Solovev decks that run PE (
Solovev_ideal_exampleand the threeSolovev_kinetic_*examples) and theregression_solovev_ideal_exampletest fixture rely on a conformal wall, because their n = 1 kink is unstable without one. They cannot be re-tuned to be stable without a wall.A scan over q₀ ∈ [1.9, 5] and κ ∈ [1.0, 1.6] found
et[1] < 0everywhere, withepstrongly negative. Solovev's pressure is linear in ψ, so the edge current is finite and drives a peeling/external kink. The pressure scalep0faconly offsets the pressure and leaves δW unchanged.The plan is:
Release note
[Wall]from any deck with[PerturbedEquilibrium], or passwall=nothingtosolve.A perturbed-equilibrium calculation no longer silently combines a with-wall plasma energy with a free-space surface inductance. A run with a wall is now an error.
Regression report
🤖 Generated with Claude Code
https://claude.ai/code/session_014wKUyAaxKdTJ5ch1boMFE1