Skip to content

fh8852v100, fh8856v100: ship majestic - #2705

Merged
openipc-ai merged 2 commits into
masterfrom
fh885xv100-majestic
Oct 28, 2026
Merged

openipc-ai merged 2 commits into
masterfrom
fh885xv100-majestic

Conversation

@openipc-ai

Copy link
Copy Markdown
Collaborator

The V100 lite images were the only Fullhan ones without the streamer:
BR2_PACKAGE_MAJESTIC had been off since before the move to
majestic-webui (#1383), so a V100 camera booted to a web UI with
nothing behind it. Enabled here exactly as on fh8852v200_lite:
MAJESTIC_FONTS, MAJESTIC_WEBUI, MAJESTIC.

The pieces it needs are now in place:

  • the toolchain has json-c again (fh8852v100: put json-c back in the toolchain and the image #2702, republished 2026-10-27);
  • majestic's own CI builds fh8852v100;
  • majestic.fh8852v100.lite.master.tar.bz2 is on S3, built from majestic
    master and published 2026-10-27. Both boards fetch that key: their
    OPENIPC_SOC_FAMILY is fh8852v100.

make BOARD=fh8852v100_lite defconfig and fh8856v100_lite both
resolve BR2_PACKAGE_MAJESTIC=y and BR2_PACKAGE_MAJESTIC_FONTS=y. json-c
comes through majestic's dependency list on fh8856v100, as it does on
fh8852v200.

No FH8852V100 or FH8856V100 camera is available, so nothing here has
run on one. The image builds on this PR are the evidence: whether each
image builds and fits its flash.

The V100 lite images were the only Fullhan ones without the streamer:
BR2_PACKAGE_MAJESTIC had been off since before the move to
majestic-webui (#1383), so a V100 camera booted to a web UI with
nothing behind it. Enabled here exactly as on fh8852v200_lite:
MAJESTIC_FONTS, MAJESTIC_WEBUI, MAJESTIC.

The pieces it needs are now in place:
- the toolchain has json-c again (#2702, republished 2026-10-27);
- majestic's own CI builds fh8852v100;
- majestic.fh8852v100.lite.master.tar.bz2 is on S3, built from majestic
  master and published 2026-10-27. Both boards fetch that key: their
  OPENIPC_SOC_FAMILY is fh8852v100.

`make BOARD=fh8852v100_lite defconfig` and `fh8856v100_lite` both
resolve BR2_PACKAGE_MAJESTIC=y and BR2_PACKAGE_MAJESTIC_FONTS=y. json-c
comes through majestic's dependency list on fh8856v100, as it does on
fh8852v200.

No FH8852V100 or FH8856V100 camera is available, so nothing here has
run on one. The image builds on this PR are the evidence: whether each
image builds and fits its flash.
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Enable Majestic on FH8852V100 and FH8856V100 lite images

🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Add the Majestic streamer to both V100 lite images so their existing web UI has a backend.
• Include Majestic fonts, matching the FH8852V200 lite package selection.
Diagram

graph TD
  A["FH8852V100 config"] --> C("Majestic streamer") --> F["Lite firmware"]
  B["FH8856V100 config"] --> C
  A --> D("Majestic fonts") --> F
  B --> D
  E("Existing Web UI") --> F
Loading
High-Level Assessment

Selecting the existing Majestic and fonts packages in each board defconfig matches the FH8852V200 lite approach without changing shared package behavior. The key remaining check is whether both images build and fit their flash; hardware behavior cannot be confirmed without a camera.

Files changed (2) +4 / -0

Other (2) +4 / -0
fh8852v100_lite_defconfigEnable Majestic and fonts for FH8852V100 lite +2/-0

Enable Majestic and fonts for FH8852V100 lite

• Selects the Majestic streamer and fonts alongside the existing Majestic web UI, so the image includes the web UI's streaming backend.

br-ext-chip-fullhan/configs/fh8852v100_lite_defconfig

fh8856v100_lite_defconfigEnable Majestic and fonts for FH8856V100 lite +2/-0

Enable Majestic and fonts for FH8856V100 lite

• Selects the same streamer and fonts packages for the FH8856V100 lite image. Its existing fh8852v100 SoC-family setting determines the Majestic artifact fetched by the package.

br-ext-chip-fullhan/configs/fh8856v100_lite_defconfig

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (1) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Two camera images lack hardware proof 📘 Rule violation ☼ Reliability
Description
The PR enables the streamer in both Fullhan V100 lite defconfigs without boot or streaming results
from either board. The description explicitly says no FH8852V100 or FH8856V100 camera was available,
so build output alone cannot verify runtime behaviour for these firmware changes.
Code

br-ext-chip-fullhan/configs/fh8852v100_lite_defconfig[R58-60]

+BR2_PACKAGE_MAJESTIC_FONTS=y
BR2_PACKAGE_MAJESTIC_WEBUI=y
+BR2_PACKAGE_MAJESTIC=y
Evidence
The checklist requires hardware evidence for any PR that can change camera firmware and explicitly
treats a statement that the change was not tested on hardware as a failure. These added Majestic
selections change both shipped images, while the PR description states that no affected camera was
available and provides only build evidence.

Rule 3: Hardware evidence is present and honest
br-ext-chip-fullhan/configs/fh8852v100_lite_defconfig[58-60]
br-ext-chip-fullhan/configs/fh8856v100_lite_defconfig[57-59]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR changes the firmware contents of two camera images by enabling Majestic, but the description confirms that neither affected board was available for hardware testing. The compliance gate requires real-camera evidence for image changes; build results alone do not demonstrate that either image boots and streams correctly.
## Fix Focus Areas
- br-ext-chip-fullhan/configs/fh8852v100_lite_defconfig[58-60]
- br-ext-chip-fullhan/configs/fh8856v100_lite_defconfig[57-59]
## Recommended Fix
Test both affected images on their corresponding cameras and add before/after evidence to the PR description, including boot results and stream behaviour or relevant logs. If hardware remains unavailable, provide the strongest permitted self-test or selector evidence while clearly documenting the limitation.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Font license reports fail 🐞 Bug ≡ Correctness
Description
The majestic-fonts package declares LICENSE as its license file, but its custom extraction step
copies only the contents of the package files directory, which contains the font and no license.
Enabling BR2_PACKAGE_MAJESTIC_FONTS for these boards causes Buildroot legal-info processing to
fail when it cannot find the declared license file.
Code

br-ext-chip-fullhan/configs/fh8856v100_lite_defconfig[57]

+BR2_PACKAGE_MAJESTIC_FONTS=y
Evidence
The changed defconfig activates the fonts package. Its makefile declares LICENSE, then copies only
files from the package files directory; that directory contains only the font, so the declared
license is absent from the extracted package source.

br-ext-chip-fullhan/configs/fh8856v100_lite_defconfig[55-59]
general/package/majestic-fonts/majestic-fonts.mk[7-11]
general/package/majestic-fonts/Config.in[1-7]
general/package/majestic-fonts/files/UbuntuMono-Regular.ttf[1-1]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new board configuration enables `BR2_PACKAGE_MAJESTIC_FONTS`, whose package metadata declares `LICENSE` but whose custom extraction step does not place a `LICENSE` file in the extracted directory. Buildroot legal-info therefore cannot collect the declared license for these images.
## Fix Focus Areas
- general/package/majestic-fonts/majestic-fonts.mk[7-11]
- general/package/majestic-fonts/files/LICENSE[1-1]
## Recommended Fix
Add the applicable Ubuntu Mono license text as `general/package/majestic-fonts/files/LICENSE`, or adjust the package metadata and extraction logic so the declared license file is present in `$(@D)` before legal-info runs. Verify the fix with the legal-info target for both newly enabled boards.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can turn on the rule miner and Qodo learns your standards from review history

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread br-ext-chip-fullhan/configs/fh8852v100_lite_defconfig
Comment thread br-ext-chip-fullhan/configs/fh8856v100_lite_defconfig
The self-test counts the matrix rows a change to the majestic package
reaches. fh8852v100_lite ships majestic now, so that count is 91.
fh8856v100_lite is not a matrix row (internal toolchain) and adds
nothing.
@openipc-ai
openipc-ai merged commit 90d3e3e into master Oct 28, 2026
48 checks passed
@openipc-ai
openipc-ai deleted the fh885xv100-majestic branch October 28, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant