Fix gc-native-roots failures on ARM Linux and macOS - #9920
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe workflow preserves the setup-provided LLVM 22 prefix for in-process linking. The YAML parser error path adds an explicit ChangesNative-roots compatibility fixes
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change restores native-roots compatibility checks on ARM Linux and macOS while preserving YAML diagnostic behavior. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
499af1a to
49c63e5
Compare
|
Landed on |
The scheduled
gc-native-rootsgate fails for two platform-specific reasons: Ubuntu ARM cannot compile the libyaml diagnostic pointer on targets where Rust'sc_charis unsigned, and the macOS stock-toolchain step overwrites the LLVM 22 prefix with Homebrew's unversioned LLVM 23 before invoking the LLVM 22 in-process backend.This casts libyaml's problem pointer through the target
std::ffi::c_chartype and preserves theLLVM_SYS_221_PREFIXexported bysetup-llvm22. The stock-toolchain assertion still removes the externaloptandclangoverrides, while the in-process backend remains linked to the ABI required byllvm-sys221.Validation:
unsafe-libyamldiagnostic expressionBun.YAML.parsecompiled probe, including the fullSyntaxErrordiagnosticperry-runtime: 3,242 passed, 4 ignored; doc tests: 8 ignoredperry-stdlib: 132 passedorigin/main, with the remaining findings unchangedFixes #9915
Summary by CodeRabbit
Bug Fixes
Documentation