Merge train: #9916, #9920 - #9923
Merged
Merged
Conversation
added 2 commits
September 6, 2026 23:14
(cherry picked from commit 49c63e5)
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge train: #9916, #9920.
The one real merge: #9916 against #9914
#9914 landed in #9922 minutes earlier, and both PRs rewrite the same
node:testreporter output lines from different directions — #9914 adds SKIP markers and directive suffixes, #9916 adds nesting and indentation. Neither side's version is correct on its own, so the spec-reportertest:passarm and the TAPokline are hand-merged to carry both: parent▶lines andevent_indent, and the﹣/✔marker withspec_directive_suffix/directive_suffix.Checked by asserting all eight distinguishing behaviours are present in the merged file rather than settling for a clean compile — the helper pair from each PR, the SKIP marker, both suffix call sites, the parent-line drain, and the indent on both the spec pass line and the TAP
okline.#9920
Two changes, both minimal.
parser.problemgets an explicit.cast::<std::ffi::c_char>(), which is the portable spelling —c_charisu8on ARM Linux andi8on x86. Andgc-native-roots.ymlstops overridingLLVM_SYS_221_PREFIXwithbrew --prefix llvm, keeping the valuesetup-llvm22provides: the stock-toolchain assertion removes the external opt/clang overrides, but llvm-sys still has to link the LLVM 22 ABI.Validation
run_lint_gates: all 64 gates passed; 2 CI-only skipped