Remove deprecated code before release 1.16 - #6472
Open
theoniko wants to merge 1 commit into
Open
Conversation
Contributor
|
You need tp remove the boost files from where they are used in cmake also. pcl/visualization/CMakeLists.txt Line 60 in a1e2c4a |
theoniko
force-pushed
the
remove-deprecated-code-before-release1.16
branch
2 times, most recently
from
August 30, 2026 19:09
1d57cd4 to
726827d
Compare
Contributor
Author
Done |
larshg
reviewed
Aug 30, 2026
| @@ -1,184 +0,0 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
This file shouldn't be removed.
larshg
reviewed
Aug 30, 2026
| * returned (true) or inside (false). | ||
| * \param limit_negative the limit_negative flag | ||
| */ | ||
| PCL_DEPRECATED(1, 16, "use bool getFilterLimitsNegative() instead") |
larshg
reviewed
Aug 30, 2026
| @@ -1,202 +0,0 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
This file shouldn't be removed
theoniko
force-pushed
the
remove-deprecated-code-before-release1.16
branch
from
August 31, 2026 04:40
726827d to
719011f
Compare
mvieth
approved these changes
Aug 31, 2026
mvieth
left a comment
mvieth
left a comment
Member
There was a problem hiding this comment.
Thanks! The failing macOS 15 check is unrelated and can be ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6470