Skip to content

Remove deprecated code before release 1.16 #6472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theoniko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove deprecated code before release 1.16 #6472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions cuda/filters/include/pcl/cuda/filters/filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,6 @@ namespace pcl_cuda
filter_limit_negative_ = limit_negative;
}

/** \brief Get whether the data outside the interval (min/max) is to be
* returned (true) or inside (false).
* \param limit_negative the limit_negative flag
*/
PCL_DEPRECATED(1, 16, "use bool getFilterLimitsNegative() instead")

@larshg larshg Aug 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this

@theoniko theoniko Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

inline void
getFilterLimitsNegative (bool &limit_negative) { limit_negative = filter_limit_negative_; }

/** \brief Get whether the data outside the interval (min/max) is to be
* returned (true) or inside (false).
* \return true if data \b outside the interval [min; max] is to be returned, false otherwise
Expand Down
168 changes: 0 additions & 168 deletions cuda/filters/include/pcl/cuda/filters/voxel_grid.h
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions filters/include/pcl/filters/voxel_grid.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,16 +478,6 @@ namespace pcl
filter_limit_negative_ = limit_negative;
}

/** \brief Get whether the data outside the interval (min/max) is to be returned (true) or inside (false).
* \param[out] limit_negative true if data \b outside the interval [min; max] is to be returned, false otherwise
*/
PCL_DEPRECATED(1, 16, "use bool getFilterLimitsNegative() instead")
inline void
getFilterLimitsNegative (bool &limit_negative) const
{
limit_negative = filter_limit_negative_;
}

/** \brief Get whether the data outside the interval (min/max) is to be returned (true) or inside (false).
* \return true if data \b outside the interval [min; max] is to be returned, false otherwise
*/
Expand Down Expand Up @@ -827,16 +817,6 @@ namespace pcl
filter_limit_negative_ = limit_negative;
}

/** \brief Get whether the data outside the interval (min/max) is to be returned (true) or inside (false).
* \param[out] limit_negative true if data \b outside the interval [min; max] is to be returned, false otherwise
*/
PCL_DEPRECATED(1, 16, "use bool getFilterLimitsNegative() instead")
inline void
getFilterLimitsNegative (bool &limit_negative) const
{
limit_negative = filter_limit_negative_;
}

/** \brief Get whether the data outside the interval (min/max) is to be returned (true) or inside (false).
* \return true if data \b outside the interval [min; max] is to be returned, false otherwise
*/
Expand Down
1 change: 0 additions & 1 deletion geometry/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ if(NOT build)
endif()

set(incs
"include/pcl/${SUBSYS_NAME}/boost.h"
"include/pcl/${SUBSYS_NAME}/get_boundary.h"
"include/pcl/${SUBSYS_NAME}/line_iterator.h"
"include/pcl/${SUBSYS_NAME}/mesh_base.h"
Expand Down
49 changes: 0 additions & 49 deletions geometry/include/pcl/geometry/boost.h
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions gpu/containers/src/device_memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
#include <pcl/gpu/containers/device_memory.h>
#include <pcl/gpu/utils/safe_call.hpp>
#include <pcl/pcl_config.h> // used for HAVE_CUDA
#include <pcl/pcl_macros.h> // used for PCL_DEPRECATED

#include <cuda_runtime_api.h>

Expand Down Expand Up @@ -164,16 +163,6 @@ pcl::gpu::DeviceMemory2D::empty() const

#else

////////////////////////// XADD ///////////////////////////////

template <typename _Tp>
PCL_DEPRECATED(1, 16, "Removed in favour of c++11 atomics")
static inline _Tp CV_XADD(std::atomic<_Tp>* addr, std::atomic<_Tp> delta)
{
_Tp tmp = addr->fetch_add(delta);
return tmp;
}

//////////////////////// DeviceArray /////////////////////////////

pcl::gpu::DeviceMemory::DeviceMemory()
Expand Down
1 change: 0 additions & 1 deletion outofcore/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ set(incs
"include/pcl/${SUBSYS_NAME}/outofcore_iterator_base.h"
"include/pcl/${SUBSYS_NAME}/outofcore_breadth_first_iterator.h"
"include/pcl/${SUBSYS_NAME}/outofcore_depth_first_iterator.h"
"include/pcl/${SUBSYS_NAME}/boost.h"
"include/pcl/${SUBSYS_NAME}/octree_base.h"
"include/pcl/${SUBSYS_NAME}/octree_base_node.h"
"include/pcl/${SUBSYS_NAME}/octree_abstract_node_container.h"
Expand Down
47 changes: 0 additions & 47 deletions outofcore/include/pcl/outofcore/boost.h
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion visualization/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ if(NOT (${VTK_VERSION} VERSION_LESS 9.0))
endif()

set(incs
"include/pcl/${SUBSYS_NAME}/boost.h"
"include/pcl/${SUBSYS_NAME}/cloud_viewer.h"
"include/pcl/${SUBSYS_NAME}/histogram_visualizer.h"
"include/pcl/${SUBSYS_NAME}/image_viewer.h"
Expand Down
4 changes: 0 additions & 4 deletions visualization/include/pcl/visualization/area_picking_event.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,6 @@ namespace pcl
: cloud_indices_ (std::move(cloud_indices))
{}

PCL_DEPRECATED(1,16,"This constructor is deprecated!")
AreaPickingEvent(int /*nb_points*/, const pcl::Indices& indices)
: AreaPickingEvent ({{"",indices}}) {}

/** \brief For situations where a whole area is selected, return the points indices.
* \param[out] indices indices of the points under the area selected by user.
* \return true, if the area selected by the user contains points, false otherwise
Expand Down
Loading
Loading