Localize Business push delivery per device - #1015
Closed
sridharkalaibala wants to merge 2 commits into
Closed
sridharkalaibala wants to merge 2 commits into
sridharkalaibala wants to merge 2 commits into
Conversation
This was referenced Sep 28, 2026
Contributor
Author
|
The complete Business companion stack, including this change, is integrated into develop through #1023. All checks, including CodeQL, passed before merge. Closing this superseded stacked PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Business push alerts previously used English for every phone. Store an optional supported language on each authenticated device registration and select fixed generic wording from 18 language packs immediately before sending or retrying. Existing session, branch, ACL, schedule and quiet-hour checks remain in force; no business figures or decisions enter lock-screen text.
GET device status negotiates the language fields with ?language=1, preserving the original response shape for strict older clients. Older servers return their original response and the companion app omits the new registration field. Legacy renewal preserves the same device's stored preference. The mobile counterpart is Posnic/posnic-business#10.
Validation: 15 Business access HTTP integration tests and seven push MongoDB integration tests pass, including negotiated/legacy status, unsupported languages, separate languages on two devices, and language changes before retry. Five transport/worker unit tests, targeted ESLint, formatting and attribution pass. The integration fixture uses MongoDB 7.0.14 explicitly. Provider calls are simulated; actual APNs/FCM and signed-device delivery and qualified translation review remain open. No CI changes. Stacked on #1014.