fix: GuildSchedule not being cached correctly + missing fields by Lumabots · Pull Request #3025 · Pycord-Development/pycord

Lumabots · 2025-12-09T19:51:26Z

Summary

summary is not complete, just check the code
I have read the Contributing Guidelines

Added
New Enums :
ScheduledEventRecurrenceFrequency (yearly, monthly, weekly, daily)
ScheduledEventRecurrenceWeekday (monday-sunday)
ScheduledEventRecurrenceMonth (january-december)

New Classes:
ScheduledEventEntityMetadata (location)
ScheduledEventRecurrenceNWeekday Represents n-weekday entries (e.g., "1st Tuesday")
ScheduledEventRecurrenceRule: Full recurrence rule with validation

Auto-validates on to_payload() serialization
New fields Guild.create_scheduled_event():

well at this point just read the code

Enforces Discord's constraints:

Frequency-specific field combinations
Mutually exclusive field checks
Valid weekday set validation for daily events
Required field enforcement for yearly events

Information

This PR fixes an issue. on_scheduled_event_delete event parameter is useless #1709
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.
AI Usage has been disclosed.
I have read the Contributing Guidelines.

…reason

…types

…from audit logs

…ation tests

pycord-app · 2025-12-09T19:51:30Z

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3025/head:pr-3025
git checkout pr-3025

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3025/head

Lumabots · 2025-12-09T19:53:17Z

Audit Logs still need to be rework (i didnt understand how it work yet)

Lumabots · 2025-12-10T07:09:48Z

should we use use_cache_on_error, instead of only use cache ? that way we will be able to fetch first and if unavailable we will get
Open of better variable name

Paillat-dev

If possible, make this pr not interfere with the recurrence one from anonymous. There will probably be merge conflicts once that one is merged, but they shouldn't both implement recurrence in a different way.

Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots · 2025-12-12T06:46:23Z

If possible, make this pr not interfere with the recurrence one from anonymous. There will probably be merge conflicts once that one is merged, but they shouldn't both implement recurrence in a different way.

when anonymous pr will be merged i'll edit it to make it work

Lulalaby · 2025-12-12T08:29:18Z

fixed ur fux

Paillat-dev

I think you mmerged by mistake this pr with the component limits one

Lulalaby · 2026-07-30T13:31:43Z

merge conflicts, please resolve

Paillat-dev · 2026-09-14T21:15:32Z

@Lumabots If you have a moment to fix merge commits

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

github-actions · 2026-09-15T17:54:30Z

This pull request does not follow the required pull request template.

Please use the default template (PULL_REQUEST_TEMPLATE.md) and fill out all required sections.

Problems detected:

The line "I have read the [Contributing Guidelines](https://github.com/Pycord-Development/pycord/blob/master/CONTRIBUTING.md)" is missing.

Lumabots · 2026-09-15T17:57:02Z

i added that line mb

Paillat-dev

Some nitpicks, other than that seems good. I remember testing awhile ago. However I think it would be beneficial to have someone else review as well

Paillat-dev · 2026-09-17T06:36:56Z

+        ) = MISSING,
+        entity_type: ScheduledEventEntityType = MISSING,
+        entity_metadata: ScheduledEventEntityMetadata | None = MISSING,
+        channel_id: int | VoiceChannel | StageChannel = MISSING,


I think it would be better to accept VoiceChannel | StageChannel | Object and then access .id, and rename the param to channel

Paillat-dev · 2026-09-17T06:39:38Z

        return utils.snowflake_time(self.id)

    @property
+    @typing_extensions.deprecated(


I think another comment of mine asked to import from typing extensions directly and not like this

vmphase · 2026-09-17T07:04:14Z

+        if (
+            entity_type is not MISSING
+            and entity_type == ScheduledEventEntityType.external
+        ):


This validation only runs when entity_type is explicitly passed. I can think of an edge case when someone edits entity_metadata on an already EXTERNAL event without repassing entity_type, an it won't get validated.

vmphase · 2026-09-17T07:09:06Z

+        self.scheduled_start_time: datetime.datetime = datetime.datetime.fromisoformat(
            data.get("scheduled_start_time")
        )
-        if end_time := data.get("scheduled_end_time", None):
-            end_time = utils.parse_time(end_time)
-        self.end_time: datetime.datetime | None = end_time
+        if scheduled_end_time := data.get("scheduled_end_time", None):
+            scheduled_end_time = datetime.datetime.fromisoformat(scheduled_end_time)
+        self.scheduled_end_time: datetime.datetime | None = scheduled_end_time


datetime.fromisoformat got full ISO 8601 parsing in 3.11 and since minimum supported version is 3.10 this will raise ValueError if, for instance, it ever gets a z-suffixed timestamp.

Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots added 6 commits December 9, 2025 15:49

at first i only wanted to add cached members...

43227c4

correcting some bs, like some unknow type added for i dont know what …

fe47678

…reason

use discord variable name, try an implementation for audit logs

fff9b3b

feat: add recurrence support for scheduled events with new enums and …

9e6a986

…types

refactor: remove ScheduledEventLocation class and related attributes …

7b2c31f

…from audit logs

feat: enhance scheduled event recurrence with validation and serializ…

5a2581e

…ation tests

Lumabots requested a review from a team as a code owner December 9, 2025 19:51

pullapprove4 Bot requested a review from Lulalaby December 9, 2025 19:51

pullapprove4 Bot added PA: All Contributors pending PA: Maintainers pending labels Dec 9, 2025

Lumabots and others added 2 commits December 9, 2025 20:51

Merge branch 'master' into on_scheduled_event_delete

973a3d2

style(pre-commit): auto fixes from pre-commit.com hooks

9d1d5d7

Lumabots and others added 2 commits December 10, 2025 13:39

revert breaking change

8c85a05

style(pre-commit): auto fixes from pre-commit.com hooks

40d79b6

Paillat-dev changed the title ~~feat: Full rework of GuildSchedule~~ fux: GuildSchedule not being cached correctly Dec 10, 2025

Paillat-dev requested changes Dec 10, 2025

View reviewed changes

Comment thread discord/enums.py Outdated

Comment thread discord/enums.py Outdated

Comment thread discord/scheduled_events.py

Comment thread discord/scheduled_events.py Outdated

pullapprove4 Bot removed PA: All Contributors pending PA: Maintainers pending labels Dec 10, 2025

Paillat-dev added API reflection Discord API isn't correctly reflected hold: testing This pull request requires further testing priority: medium Medium Priority labels Dec 10, 2025

Update discord/enums.py

b5dc3e9

Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lulalaby changed the title ~~fux: GuildSchedule not being cached correctly~~ fix: GuildSchedule not being cached correctly Dec 12, 2025

Lumabots and others added 2 commits May 23, 2026 12:31

paillait comment

4742b65

style(pre-commit): auto fixes from pre-commit.com hooks

fe312f0

Paillat-dev moved this from Done to Todo in Pycord May 23, 2026

Paillat-dev requested changes Jun 7, 2026

View reviewed changes

Comment thread discord/ui/core.py Outdated

Paillat-dev and others added 5 commits June 10, 2026 12:04

Merge branch 'master' into on_scheduled_event_delete

44ae828

Fix a bunch of stuff

e216d2e

chore: Undo, will do this later

ea24bd3

style(pre-commit): auto fixes from pre-commit.com hooks

373c815

docs: CHANGELOG.md

c8536da

Paillat-dev requested a review from a team as a code owner June 10, 2026 11:17

Paillat-dev requested a review from a team June 10, 2026 11:17

pre-commit-ci Bot and others added 2 commits June 10, 2026 11:17

style(pre-commit): auto fixes from pre-commit.com hooks

cc87293

fix: Allow because of deprecation

d87c944

Paillat-dev modified the milestones: 2.8.1, 2.9.0rc1 Jun 10, 2026

Paillat-dev removed the hold: changelog This pull request is missing a changelog entry label Jun 10, 2026

Paillat-dev requested a review from ToothyDev June 10, 2026 11:30

Paillat-dev mentioned this pull request Sep 14, 2026

fix(scheduled_events): decrement subscriber_count on user_remove #3387

Merged

12 tasks

Paillat-dev requested a review from vmphase September 14, 2026 21:15

Merge branch 'master' into on_scheduled_event_delete

73eebe1

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots requested a review from a team as a code owner September 15, 2026 17:54

github-actions Bot added the invalid This doesn't seem right label Sep 15, 2026

github-actions Bot closed this Sep 15, 2026

Paillat-dev requested changes Sep 17, 2026

View reviewed changes

vmphase requested changes Sep 17, 2026

View reviewed changes

Update CHANGELOG.md

4838467

Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Uh oh!

Conversation

Lumabots commented Dec 9, 2025 • edited by Paillat-dev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Information

Checklist

Uh oh!

pycord-app Bot commented Dec 9, 2025

Uh oh!

Lumabots commented Dec 9, 2025

Uh oh!

Lumabots commented Dec 10, 2025

Uh oh!

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lumabots commented Dec 12, 2025

Uh oh!

Lulalaby commented Dec 12, 2025

Uh oh!

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Lulalaby commented Jul 30, 2026

Uh oh!

Paillat-dev commented Sep 14, 2026

Uh oh!

github-actions Bot commented Sep 15, 2026

Uh oh!

Lumabots commented Sep 15, 2026

Uh oh!

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Paillat-dev Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

Paillat-dev Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

vmphase Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

vmphase Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Lumabots commented Dec 9, 2025 •

edited by Paillat-dev

Loading