Repository navigation
Conversation
…plate It used to end when the template SPR goes under 1e-4 ADC#. Now it needs to stay within +/- 1w-4 ADC# for 20 nanoseconds. This should make it possible to include undershootings. All these parameters are currently hard-coded.
…icles that might cross cathode
Good catches on names and strings. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_28_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
I forgot that this requires a sequential CI build given the data product changes. I'll run that and update here. |
|
Sequential build completes with only resource warnings. This is expected since release management has not merged the retuning PR. Proceeding with the merge! |
This is a reprise of PR #922, created rebasing commit e17d5cd to the current
developbranch.Unit tests have been run to verify the formal correctness of the FHiCL configurations and some more tests, however there has not been any physics revalidation.
P.S. I added a "fix" for the FHiCL unit test which failed in
develop.