Repository navigation

Light and overlay fixes — second try [`develop`] - #933

Merged

jas1005 merged 167 commits into

SBNSoftware:developfrom

PetrilloAtWork:feature/pmtsim_gainDevelopTakeTwo

Oct 28, 2026

Merged

Light and overlay fixes — second try [`develop`]#933
jas1005 merged 167 commits into
SBNSoftware:developfrom
PetrilloAtWork:feature/pmtsim_gainDevelopTakeTwo

Commits on Oct 26, 2026
- fix sim label for PDFastSim
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  edd20cc
- detsim_opdetonly_icarus.fcl: simulate only optical detector digitization
  PetrilloAtWork
  committed
  de89e10
- Changed determination of the end of single photoelectron response template
  PetrilloAtWork
  committed
  5409a1d
- Updated `FastGaussianNoiseGeneratorAlg` documentation
  PetrilloAtWork
  committed
  7b6face
- SelectCathodeCrossingGenParticles: selects generated events with particles that might cross cathode
  PetrilloAtWork
  committed
  9e339a9
- make MC2-var4 tune standard
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  82223e7
- simulate pmt timing delays in mc
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  cd06cff
- disable pmt mc noise for overlays
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  2d11c22
- add ophituncorrected + ophit flow for mc
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  a4146b1
- update stage0 flow for overlays
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  a48cc68
- small fix
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  b2d33fd
- prelimanary reco gain tuning
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  68cbad3
- add SPRRun3, make SPRRun2 default
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  5204bc5
- nullify flash calibration
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  5cc1b37
- add run3 opdet tune, make run2 default
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  3921788
- change run3->run4, update gain
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  e5b3da5
- add run4 detsim fhicls
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  0a3ae93
- first attempt at detsim reprocessing fhicl
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  ab770f7
- fix typo
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  cac28c9
- Trigger simulation modules: support input tag with process name
  PetrilloAtWork
  committed
  a4cc484
- Apply suggestions from GIT Copilot code review
  
  PetrilloAtWork
  and
  Copilot
  committed
  d614320
- fix to detsim reprocessing
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  bfcfa5d
- reprocessing opdetonly overlay fhicl
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  726318d
- leave default tags
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  e721b90
- add initial recalibrator module
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  e6c5793
- fix compilation for recalibrator
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  3f89041
- link online corrections service to recalibrator
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  4ef2c78
- link locally-provided old timing corrections
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  daba6e6
- fix timing recalibration
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  d523817
- remove custom config, fixed indentation
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  e5b41b5
- chop off flat waveform tail in overlays
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  44b2db7
- restore legacy defaults for backward compatibility
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  648d4eb
- fixed documentation
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  dcce54b
- add opdetonly MCstage0 fhicls for reprocessing
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  77f55d8
- fix stage0 reprocessing fhicls
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  716dc1a
- adjust stage1 compatibility
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  eee665c
- add data reprocessing fhicl(s)
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  d399fa9
- update file names
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  01ac54a
- ICARUSFlashFinder: added Doxygen-style header
  PetrilloAtWork
  committed
  538f8c1
- ICARUSFlashFinder: turned into shared module
  PetrilloAtWork
  committed
  a14e718
- ICARUSFlashFinder: FHiCL configuration validation
  PetrilloAtWork
  committed
  91df0e2
- ICARUSFlashFinder: code updates
  PetrilloAtWork
  committed
  2f42a84
- ICARUSFlashFinder: removed hit recalibration (PECalib)
  PetrilloAtWork
  committed
  1e1c09e
- dump_opflashes_icarus.fcl: dump reconstructed flashes on text file
  PetrilloAtWork
  committed
  086ff13
- Adopting corrections from GitHub Copilot
  PetrilloAtWork
  committed
  6fb3bba
- Removed obsolete icarus_flashcalib.fcl
  PetrilloAtWork
  committed
  ed3a38e
- tentative debug tree
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  7846864
- tweaks for success build
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  ffabf56
- move to other loop
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  32f563d
- save debug only with photons
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  1e848ab
- store photon start position in debug
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  e58896b
- remove old variables
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  fcb6209
- remove forgotten variable
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  4a2ba82
- first commit, compiles and does nothing
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  86d75a9
- changed namespaces
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  4c467a4
- basic struct/map for holding spe areas
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  cf62423
- working version getting area from database and initial database file
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  fde331a
- updated tags in db file
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  d1f1c7d
- add fcl file for debugging spe area service
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  62c43e0
- PMT calibration service code review
  PetrilloAtWork
  committed
  1d01a04
- update pmt calibration service provider
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  b3b408f
- removed db file + copilot suggestions
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  73c349d
- interface SPEArea DB with ophit recalibrator
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  9584488
- fix cout of current areatag
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  fdb7474
- rework stage0 optical workflow for data, mc, overlay
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  76343d5
- simulate pmt timing delays only for overlay flow
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  c0e5cc5
- remove ophituncurrected from legacy mc flow
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  865dacf
- tune mcophit
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  7f76573
- make applytimingdelays explicit
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  a6667e6
- add run3/4 stage0 overlay light tunes
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  8124684
- remove useless while loop
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  d430b4f
- fix-up comment
  
  mvicenzi
  and
  PetrilloAtWork
  committed
  b6cb7ff
- use microseconds, pass service as pointer not reference
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  b796cb6
- fixes + indentation
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  bde1539
- minor fixes
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  a3ee2f3
- add documentation in fhicls
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  31291e9
- use mf:errorlog
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  53981a8
- improve documentation
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  4368b92
- more documentation please
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  7e1d4c5
- augment gain db service
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  069be53
- add gain service provider interface
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  9b792e4
- fix linking for db interface
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  2a5a876
- update speareas database tag
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  2436565
- add pmt channel status service
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  3b03a19
- tie up the service
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  29b6454
- fix linking
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  5936d38
- change kOn to kGood
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  d004863
- use channel status service in pmtsim
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  d9a7485
- update fcls for legacy vs overlay flow
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  3cb725a
- switch reco to local entry point
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  42cc634
- fix sharing factory with ped algos
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  ec93322
- fix standard calibrator + add channel status service
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  f7ad257
- remove conflicting defaults
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  6ec0b4d
- remove mcophit from mc-overlays
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  6454ab6
- never hold service pointers, you fool
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  1789bb1
- expose integral and bias from sampled waveform tool
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  714c60a
- plug in db gain and spread in simulation
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  13e288e
- fix variable name
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  96769b8
- keep database use false for default non-overlay MC
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  944c8e4
- add forgotten service
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  05a4e44
- improve prints
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  9141308
- better printing
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  c4db4f1
- apply integral definition bias
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  870b46b
- update db tag
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  3f7912e
- update variable names
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  4a0e627
- TailNSigmaThreshold is wrong, should be TailNSigma
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  4666b6f
- re-tune flash algo for new SPEAreas to match past performance
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  db01bec
- add ophit integral to flashana tree
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  3bc4641
- add run number ovverides to PMT db services
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  cc5d496
- introducing vertical track flash/wf module
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  69396b5
- make waveforms optional, add total PE per pmt
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  4816011
- update transit time
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  f02b168
- TriggerSimulationOnGates: added fixed configurable trigger delay
  PetrilloAtWork
  committed
  d1ada64
- Update after TimeIntervalConfig breaking change
  PetrilloAtWork
  committed
  a846553
- SimPMTIcarus: reworked internals
  PetrilloAtWork
  committed
  6160281
- SimPMTIcarus: produce baseline data products and associations
  PetrilloAtWork
  committed
  250896e
- PMTsimulationAlg: changed waveform superposition rounding, and default baseline
  PetrilloAtWork
  committed
  9df8c11
- Maintenance commit
  PetrilloAtWork
  committed
  2c8db96
- OverlayPMTwaveforms: dedicated PMT waveform overlay module
  PetrilloAtWork
  committed
  46e5513
- Simulation timescale changed to the "shifted" time
  PetrilloAtWork
  committed
  2f66b0e
- Trigger configuration maintenance
  PetrilloAtWork
  committed
  cc05e07
- MC trigger simulation baselines now read from a data product.
  PetrilloAtWork
  committed
  51236d9
- Trigger simulation gate now refers to simulation time instead of beam gate time
  PetrilloAtWork
  committed
  dc2640b
- TriggerSimulationOnGates: fix beam gate output
  PetrilloAtWork
  committed
  66b38cf
- Added trigger time delay to the trigger simulation
  PetrilloAtWork
  committed
  66d9c3b
- Filtering disables in Stage0 MC to allow for fast cloning
  PetrilloAtWork
  committed
  7acda75
- Retuned trigger-flash delay in TPC-PMT matching
  PetrilloAtWork
  committed
  621c603
- Tuned beam gates to Run2 data
  PetrilloAtWork
  committed
  c337bcf
- Using SBN (shared) GENIE configuration for BNB and NuMI
  PetrilloAtWork
  committed
  323cefb
- Tuned BNB gate again (after enabling neutrino propagation time)
  PetrilloAtWork
  committed
  5d8a915
- manageDataRunDefinitions.py version 1.1
  PetrilloAtWork
  committed
  9ea6dab
- Removed configuration override used in development
  PetrilloAtWork
  committed
  dfbc49f
- Indentation fix
  PetrilloAtWork
  committed
  8e5748d
- TriggerSimulationOnGates module: fixed trigger timestamp encoding
  PetrilloAtWork
  committed
  aa8f581
- TriggerSimulationOnGates: timestamp can be imported from a data product
  PetrilloAtWork
  committed
  715693b
- TriggerSimulationOnGates module: minor bug fixes
  PetrilloAtWork
  committed
  4e95dc7
- TriggerSimulationOnGates module: documentation fixes
  PetrilloAtWork
  committed
  f5b4b52
- CRT hit reconstruction: add time offset only in data
  PetrilloAtWork
  committed
  2f1aaab
- CRT hit reconstruction: ignore trigger timestamp for simulation
  PetrilloAtWork
  committed
  1ac889b
- "Answered" Tracy Usher's questions on Stage0 workflow
  PetrilloAtWork
  committed
  a27ef51
- MC Stage0 CRT/PMT matching uses shifted trigger to determine in-beamness
  PetrilloAtWork
  committed
  4399795
- Code maintenance
  PetrilloAtWork
  committed
  1706ed0
- RebuildShiftedTrigger: makeup module for reprocessing Monte Carlo samples
  PetrilloAtWork
  committed
  bcaebdb
- Minor fix to simulation workflow
  PetrilloAtWork
  committed
  a29100a
- FixBeamGateInfo: changed gate selection
  PetrilloAtWork
  committed
  8aed23c
- OverlayPMTwaveforms: more information when baseline not found
  PetrilloAtWork
  committed
  e115c02
- MC reprocessing updated to reflect changes in workflow
  PetrilloAtWork
  committed
  f2a7353
- DataProductReader: prints available data products and their tags
  PetrilloAtWork
  committed
  52964a4
- Apply suggestions from code review
  
  committed
  4540c82
- Custom changes after automated review report
  PetrilloAtWork
  committed
  9bbd563
- Fixed Run4 reprocessing misfiring FHiCL override
  
  PetrilloAtWork
  and
  Copilot
  committed
  0778145
- change default pmt channel status to off
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  a35faba
- detsim_opdetonly_icarus_overlay_reprocessing_run2.fcl: fixed time reference
  PetrilloAtWork
  committed
  e1cb944
- Updated CAFMaker configuration (applies shift to beam gate time)
  PetrilloAtWork
  committed
  b6a428c
- bugfix: do not recalibrate hits flagged as bad in status db
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  5dc8636
- include initial tail suppression
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  8db14fb
- fix casting
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  c9c3dad
- move printout
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  9140849
- fix time constant
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  5b08b86
- test distance dependent survival
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  b2bc777
- update run2 tailsupp and survival distance tune
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  00b4bc4
- improve documentation, clarify currently missing run4 tune
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  66af8f1
- Update icaruscode/PMT/Algorithms/PMTsimulationAlg.cxx
  
  mvicenzi
  and
  PetrilloAtWork
  committed
  0939c7c
- Apply suggestion from @PetrilloAtWork
  
  mvicenzi
  and
  PetrilloAtWork
  committed
  9323a37
- switch to fhicl::OptionalTable + print DistanceSurvival settings as well
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  6745ebc
- add reprocessing stage0 fhicls with no DB use
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  9cdd593
- Added missing FHiCL unit test exception
  PetrilloAtWork
  committed
  704dab7

Commits

Commits on Oct 26, 2026