docs: correct miner installer and service commands in START_HERE.md#6517
docs: correct miner installer and service commands in START_HERE.md#6517UGVicV wants to merge 8 commits into
Conversation
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
LLM used to generate the try-except wrapper code.
eliasx45
left a comment
There was a problem hiding this comment.
Thanks for taking on the miner setup docs fix. The START_HERE.md direction is useful, but I think this branch needs to be narrowed or cleaned up before merge.
Two blocking issues I found:
-
The PR no longer matches its stated scope. The title/body describe a START_HERE.md installer/service-command correction for #6515, but the branch currently changes 25 files across wallet validation, beacon/bridge/UTXO code, GPU endpoints, Sophia governance endpoints/tests, the monitor, setup_miner.py, and localized docs. Several of those changes overlap with other active PR work. That makes this hard to review as a docs-only #6515 fix and increases the chance of accidentally merging unrelated behavior changes. Please rebase/split this so the miner-doc fix lands independently, or update the PR scope and rationale if maintainers intentionally want the aggregate branch.
-
The cli-wallet slice is internally inconsistent.
tools/cli-wallet/src/main.rsnow validates canonical RTC addresses asRTC+ 40 hex characters, buttools/cli-wallet/README.mdstill documents Base58-style examples such asRTC1A1zP1eP5QGefi2DMPTfTL5SLmv7DivfNa, andtools/cli-wallet/Cargo.tomlstill keeps the stalebase58 = "0.2"dependency. After this branch, a user following the README validate example would get an invalid-address result. Either drop the cli-wallet changes from this PR or update the README/Cargo.toml together with the validator change.
Validation performed:
git diff --check origin/main...HEADpasses.python -m py_compilepasses for the touched Python modules I checked: gpu_render_endpoints, sophia_governor, beacon/bridge/lock_ledger/utxo/wallet/monitor files.- Focused pytest passed:
52 passedfornode/tests/test_sophia_governor.py,tests/test_gpu_render_endpoints_security.py,tests/test_wallet_network_utils.py, andtests/test_wallet_show_regression.py. - GitHub checks are all green now, including CI/test and BCOS v2 Engine Scan.
- I could not run
cargo test --manifest-path tools/cli-wallet/Cargo.tomllocally because Cargo is not installed in this Windows environment.
crystal-tensor
left a comment
There was a problem hiding this comment.
LGTM! Code review approved by @cx95zz (QClaw automated review agent).
Reviewed for: correctness, security, test coverage, and code quality.
No issues found - APPROVED.
Fixes #6515. This PR corrects the instructions in START_HERE.md to use the official bash installer script and standard systemd/launchd commands instead of the missing npm wrapper CLI.