[Klaud Cold] Remove pointers to the deleted single-node bash folders; delete configs/deprecated and amd_utils/deprecated - #3463
Conversation
|
Thanks for the contribution!
中文感谢你的贡献！
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.
Looks good — mostly mechanical cleanup/restoration (removing dead references to the deleted directory, restoring the 14 kernel-config files, trimming launcher branches, updating docs). One inline nit flags a stale comment block that no longer matches the trimmed config; it doesn't affect behavior.
Extended reasoning...
The change touches benchmark/config YAML, shell launcher scripts, restored JSON kernel-config data files, and docs — no auth/crypto/permission code and no security-sensitive surface. The single confirmed finding is a stale explanatory comment in configs/amd-master.yaml (describing bands and a companion key this same diff removed) which is cosmetic/documentation-only, not a functional bug, so it doesn't block approval.
| # Kimi-K3 MXFP4 agentic-coding benchmark on MI355X via ATOM with DSpark | ||
| # speculative decoding. Acceptance is pinned to the committed golden curve in | ||
| # golden_al_distribution/kimik3_dspark_probabilistic_sample_method_block_rejection_sample_method.yaml |
There was a problem hiding this comment.
🟡 Nit (optional): maintainers reading amd-master.yaml get explanatory comment blocks that still describe search-space arms and a sibling config key this PR deleted, so the docs no longer match the config. The kimik3-fp4-mi355x-atom-agentic-mtp comment here says 'Companion to kimik3-fp4-mi355x-vllm-agentic-mtp' (that key is deleted by this same diff) and still describes the mid (14,16) and throughput (48,56,72) LMCache/DCP8 bands and two dram-utilization blocks, but the search-space below now has only the interactive band and one dram-utilization: 0.343. …
Why this was flagged
…Fix: update or remove these comments to match the trimmed search-space at all three sites: configs/amd-master.yaml:655-673 (kimik3), :1339-1345 (glm5.2, still describes the removed DCP4 C16-C48 band), and :700-701 (minimaxm3, '0.687 targets ~256 GB/rank on the dram-offload arms' though none remain).
The kimik3-fp4-mi355x-atom-agentic-mtp block comment at configs/amd-master.yaml:655-673 references 'Companion to kimik3-fp4-mi355x-vllm-agentic-mtp', a config key this same diff removes from this file entirely, and describes a 'mid (14,16)' and 'throughput (48,56,72)' LMCache/dcp-size 8 band plus a second dram-utilization: 0.513 block, none of which exist in the search-space at line ~684-686 anymore (only { tp: 8, kv-offloading: none, conc-list: [1, 4] } remains). Same staleness at :1339-1345 (glm5.2-fp4-mi355x-atom-agentic-mtp, still says large concurrency C16-C48 adds DCP4/LMCache though that arm was deleted) and :700-701 (minimaxm3-fp4-mi355x-atom-agentic-mtp, '0.687 targets ~256 GB/rank on the dram-offload arms' though the two LMCache arms were deleted, leaving only kv-offloading:…
Verification: nit. This is a comment-staleness issue introduced by this diff (comments are not executed, so nothing functional breaks; base branch had matching comments+arms). Site 1 (kimik3), configs/amd-master.yaml:655-675: line 660 says "# Companion to kimik3-fp4-mi355x-vllm-agentic-mtp: same checkpoint, same runner." but the diff deletes the whole kimik3-fp4-mi355x-vllm-agentic-mtp: block from this…
…/single_node/agentic reached it: - Drop the 17 search-space entries without srt-recipe: six configs that were entirely bash-based (both B300 Qwen3.5 power A/B keys, qwen3.8next H100, Kimi-K3 and MiniMax-M3 MI355X vLLM, DSv4.1 Flash MI355X ATOM) and the ATOM LMCache DRAM-offload arms of Kimi-K3, MiniMax-M3 and GLM-5.2 on MI355X. - Remove the dead dsv41flash bash branches in the GB200/GB300 launchers and the MiniMax-M3 ATOM script special case in the MI355X launcher. - Restore the DSv4.1 Flash H100/H200 block32 installers and kernel configs under benchmarks/multi_node/srt-slurm-recipes/configs/dsv41flash-block32/ and repoint the setup scripts, which the live single-node H100/H200 SGLang AgentX recipes run and #3461 broke. - Point docs and comments at the srt-slurm recipes and srt_agentic.sh. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…toring them Per review: do not re-add the block32 installers and kernel configs. Remove the restored dsv41flash-block32 assets, the two block32 setup scripts, the recipes' setup_script entries and the H200 DSV41_BLOCK32_TP env vars; the H100/H200 SGLang AgentX recipes now run with SGLang's default tilings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- Delete configs/deprecated/{amd,nvidia}-master.yaml; nothing reads them.
AGENTS.md, docs/configuration-procedures and the Claude review prompt now
say retired entries are deleted, with git history and perf-changelog.yaml
as the record.
- Rewrite the add-model-hardware playbook and configuration procedures for
srt-slurm recipes instead of bash scripts under fixed_seq_len/.
- Point MODELS links, the KLAUD_DEBUG example and a deprecated multi-node
comment away from the deleted folders.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
5f8bd8c to
43cc8af
Compare
functionstackx
changed the title
Nothing loads these archived AMD server-registry files or glm5_setup.sh; the live registries are the models*.yaml and node_excludes.yaml beside them. configuration-procedures now says retired AMD registry entries are deleted rather than moved into deprecated/. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
functionstackx
changed the title
Leave the historical waiver record unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 participant
Summary
Follow-up to #3461 and #3464, which deleted
benchmarks/single_node/agentic/andbenchmarks/single_node/fixed_seq_len/: remove everything that still pointed at them, and deleteconfigs/deprecated/andbenchmarks/multi_node/amd_utils/deprecated/. Rebased onmainafter #3464.1. DSv4.1 Flash H100/H200 SGLang AgentX: drop the block32 tilings
The single-node recipes
dsv41flash/sglang/h{1,2}00-fp4-mtp/agentic.yamlransetup_script: dsv41flash-h{1,2}00-block32.sh, which loaded the block32 installers andkernel_configs/from the deleted folder (broken onmainsince #3461). The tilings are not re-added: this deletes both setup scripts, drops the recipes'setup_scriptentries and the H200 recipe's 16DSV41_BLOCK32_TPenv vars. Both recipes now run with SGLang's default kernel tilings (tiling only; checkpoint data, scales and dtypes were never changed by the setup script).2. Remove the 17 bash-only AgentX search-space entries
Every single-node
agentic-codingentry withoutsrt-recipe:ran a deleted script. Removed:qwen3.5-fp8-b300-sglang-agentic-power-abqwen3.5-fp4-b300-sglang-agentic-power-abqwen3.8next-fp8-h100-sglang-agentic-mtpkimik3-fp4-mi355x-vllm-agentic-mtpminimaxm3-fp4-mi355x-vllm-agentic-mtpdsv41flash-fp4-mi355x-atom-agentic-dsparkkimik3-fp4-mi355x-atom-agentic-mtpminimaxm3-fp4-mi355x-atom-agentic-mtpglm5.2-fp4-mi355x-atom-agentic-mtpThe ATOM LMCache arms can't move to srt-slurm yet (srtctl reserves ATOM's
kv-transfer-configfor disaggregated workers); the recipe header comments now say they were removed.srt-slurm-recipes/kimik3/vllm/mi355x-fp4-mtp/agentic.yamlis kept (it points nowhere legacy) and could revive the Kimi-K3 vLLM config.3. Launchers
launch_gb200-nv.sh/launch_gb300-nv.sh: remove the deaddsv41flashbash branch (theSRT_RECIPEbranch above it already exits for every single-node AgentX point).launch_mi355x-amds.sh: remove theminimaxm3_fp4_mi355x_atom_mtp.shspecial case.4. Docs and comments
MODELS(_zh).mdscenario table,docs/index(_zh).md,docs/DOCUMENTATION_PLAN(_zh).md, the codeowner verify prompt's applicability rule,KLAUD_DEBUG.md, and two code comments now point at the srt-slurm recipes /benchmarks/srt_agentic.shor note the removal.Intentionally left:
docs/waiver/2508.md(historical waiver record), dated history (MODELS deprecation note for #2493,perf-changelog.yaml), the SHA-pinned PR #3205 example in the codeowner prompt, and thefixture_*.shstrings inutils/test_srt_single_node.pythat exercise the generic launcher fallback.5. Delete
configs/deprecated/and move the docs to the srt-slurm flow#3464 merged with only its first commit (the
fixed_seq_len/deletion); its follow-up is carried here:configs/deprecated/{amd,nvidia}-master.yaml(nothing reads them).AGENTS.md"Deprecating benchmark configs",docs/configuration-procedures(_zh).mdand the Claude review prompt in.github/workflows/claude.ymlnow say retired entries are deleted, with git history andperf-changelog.yamlas the record..claude/commands/add-model-hardware.md(the add-model-hardware skill) and the configuration-procedures new-config steps for srt-slurm recipes: no bash script underfixed_seq_len/, no launcher routing,USE_CHAT_TEMPLATE: 'true'for MTP.MODELS(_zh).md: links intoconfigs/deprecated/become plain text; present-tense "archived in" statements now say the archive was removed.benchmarks/multi_node/amd_utils/deprecated/(archivedmodels*.yaml,node_excludes.yaml,glm5_setup.sh); nothing loads them, the live registries sit beside it inamd_utils/. configuration-procedures now says retired AMD registry entries are deleted too.Test plan
generate_sweep_configs.py full-sweepover both master configs passes (it fails onmainbecause of thecluster:b300-nvpower-ab keys this PR deletes); the three trimmed ATOM configs generate 23 GPU-resident srt points; no single-node agentic entry withoutsrt-recipe:remains.bash -non the three edited launchers andserver_sglang.sh.utils/test_srt_single_node.py,utils/test_srt_cluster_config.py,utils/matrix_logic,utils/changelog_gate_tests: 439 passed, 14 failed, identical failure set onmain(pool-launcher tests hitmapfile: command not foundon macOS bash 3.2).perf-changelog.yamlchange, so no sweep is triggered.🤖 Generated with Claude Code