Skip to content

add write tool formatters - #1017

Merged
LasmarKhalifa merged 1 commit into
mainfrom
06-30/pi-tool-formatter-write
Aug 5, 2026
Merged

add write tool formatters#1017
LasmarKhalifa merged 1 commit into
mainfrom
06-30/pi-tool-formatter-write

Conversation

@LasmarKhalifa

@LasmarKhalifa LasmarKhalifa commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Closes #1025

LasmarKhalifa commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from bee016d to 852ae68 Compare July 2, 2026 16:01
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from 852ae68 to f2399f0 Compare July 3, 2026 14:50
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-read branch from af63b1e to 1522547 Compare July 3, 2026 14:50
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from f2399f0 to 4166e5d Compare July 3, 2026 15:30
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-read branch from 1522547 to 2162423 Compare July 3, 2026 15:30
@LasmarKhalifa
LasmarKhalifa marked this pull request as ready for review July 3, 2026 16:30

@mathiusj mathiusj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write formatter — one inconsistency with the sibling formatters.

Comment thread lib/roast/cogs/agent/providers/pi/messages/tool_call_message.rb Outdated
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-read branch from 2162423 to 9774c62 Compare July 10, 2026 15:23
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from 4166e5d to 1d5f2cb Compare July 10, 2026 15:23
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-read branch from 9774c62 to eecfae1 Compare July 10, 2026 15:50
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch 3 times, most recently from 0c38e90 to 5e31fef Compare July 10, 2026 16:33
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-read branch from eecfae1 to daeaf21 Compare July 10, 2026 16:38
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from 5e31fef to 32856c2 Compare July 10, 2026 16:38
@LasmarKhalifa
LasmarKhalifa requested a review from mathiusj July 10, 2026 18:14
@LasmarKhalifa LasmarKhalifa linked an issue Jul 13, 2026 that may be closed by this pull request
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from 32856c2 to 80dee98 Compare July 14, 2026 20:37
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-read branch from daeaf21 to e3989e8 Compare July 14, 2026 20:37
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from 80dee98 to d27fc00 Compare July 30, 2026 14:41
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-read branch from e3989e8 to 27e0d9d Compare July 30, 2026 14:41

LasmarKhalifa commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Aug 5, 3:41 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 5, 3:47 PM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 5, 3:47 PM UTC: @LasmarKhalifa merged this pull request with Graphite.

@LasmarKhalifa
LasmarKhalifa changed the base branch from 06-30/pi-tool-formatter-read to graphite-base/1017 August 5, 2026 15:44
@LasmarKhalifa
LasmarKhalifa changed the base branch from graphite-base/1017 to main August 5, 2026 15:45
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from d27fc00 to 1248aa7 Compare August 5, 2026 15:46
@LasmarKhalifa
LasmarKhalifa merged commit f553fb3 into main Aug 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pi format_write tool implementation

2 participants