Skip to content

add ls tool formatters - #1021

Merged
LasmarKhalifa merged 1 commit into
mainfrom
07-02/pi-tool-formatter-ls
Aug 5, 2026
Merged

add ls tool formatters#1021
LasmarKhalifa merged 1 commit into
mainfrom
07-02/pi-tool-formatter-ls

Conversation

@LasmarKhalifa

@LasmarKhalifa LasmarKhalifa commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #1029

This was referenced Jul 2, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@LasmarKhalifa Graphite App

LasmarKhalifa commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-ls branch from 498aaf4 to da7caa7 Compare July 3, 2026 14:50
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch 2 times, most recently from eba0fd6 to 96d8a9b Compare July 3, 2026 15:06
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-ls branch 2 times, most recently from 38a75a7 to a28917e Compare July 3, 2026 15:30
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from 96d8a9b to 554abfb Compare July 3, 2026 15:30
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-ls branch from a28917e to a083596 Compare July 3, 2026 16:02
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch 2 times, most recently from 8a4b6f3 to 621fd97 Compare July 3, 2026 16:12
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-ls branch from a083596 to bb7da93 Compare July 3, 2026 16:12
@LasmarKhalifa
LasmarKhalifa marked this pull request as ready for review July 3, 2026 16:29
mathiusj
mathiusj reviewed Jul 3, 2026
View reviewed changes

@mathiusj mathiusj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ls formatter looks good — tops off a clean stack.

Comment thread lib/roast/cogs/agent/providers/pi/messages/tool_result_message.rb
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from 621fd97 to dd0821d Compare July 10, 2026 15:23
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-ls branch 2 times, most recently from 3ee5f3f to 6f55fec Compare July 10, 2026 15:50
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from dd0821d to 1d2092c Compare July 10, 2026 15:50
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-ls branch from 6f55fec to 6b922f5 Compare July 10, 2026 16:13
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch 2 times, most recently from eef857c to b9177ad Compare July 10, 2026 16:33
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-ls branch 2 times, most recently from 7d498e8 to e87c011 Compare July 10, 2026 16:38
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from b9177ad to 9857673 Compare July 10, 2026 16:38
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-ls branch from e87c011 to cb07d29 Compare July 10, 2026 18:11
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from 9857673 to 5cbb42c Compare July 10, 2026 18:11
@LasmarKhalifa LasmarKhalifa linked an issue Jul 13, 2026 that may be closed by this pull request
Pi format_ls tool implementation #1029
Closed
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from 5cbb42c to 5f80803 Compare July 14, 2026 20:37
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-ls branch from cb07d29 to 274439f Compare July 14, 2026 20:37
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from 5f80803 to ad2c314 Compare July 30, 2026 14:41
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-ls branch 2 times, most recently from c185c1a to f878da1 Compare July 30, 2026 19:52
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from ad2c314 to 2f1e72a Compare July 30, 2026 19:52
@LasmarKhalifa Graphite App

LasmarKhalifa commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Aug 5, 3:41 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 5, 3:56 PM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 5, 3:56 PM UTC: @LasmarKhalifa merged this pull request with Graphite.

@LasmarKhalifa
LasmarKhalifa changed the base branch from 07-02/pi-tool-formatter-find to graphite-base/1021 August 5, 2026 15:53
@LasmarKhalifa
LasmarKhalifa changed the base branch from graphite-base/1021 to main August 5, 2026 15:54
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-ls branch from f878da1 to 7e17daf Compare August 5, 2026 15:55
@LasmarKhalifa
LasmarKhalifa merged commit 298cf50 into main Aug 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathiusj mathiusj mathiusj approved these changes
@nfgrep nfgrep Awaiting requested review from nfgrep nfgrep is a code owner
@dersam dersam Awaiting requested review from dersam dersam is a code owner
@juniper-shopify juniper-shopify Awaiting requested review from juniper-shopify juniper-shopify is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pi format_ls tool implementation

2 participants

@LasmarKhalifa @mathiusj