test(datagrid): accept the observed value font and editor settings in the source guards - #2942
Merged
Merged
Conversation
… the source guards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2940 merged one commit short: this fix was committed locally and not pushed yet, so
mainfails the "Stored value font" suite.#2940 made views observe the shared
ThemeEngineandAppSettingsManager, which changed the text two source guards match:standaloneValueViewsResolveTheValueFontrequired the literalThemeEngine.shared.valueFont. A view now reads it through thethemeEngineit observes, and a static helper still reads the shared engine, so the guard accepts either spelling.jsonEditorWatchesEveryAppearanceChangerequiredonChange(of: AppSettingsManager.shared.editor). That form never fired: the valueonChange(of:)compares is read while the body is built, and the body did not observe the settings. The guard now requires the observed manager andonChange(of: settingsManager.editor).ValueFontTestspasses locally, 7 cases.