Skip to content

test(datagrid): accept the observed value font and editor settings in the source guards #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
Sep 17, 2026
Merged

test(datagrid): accept the observed value font and editor settings in the source guards #2942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions TableProTests/Theme/ValueFontTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,13 @@ struct ValueFontTests {
"TablePro/Views/Results/PhpViewerView.swift",
]

/// Either spelling names the value font. A view reads it through the `themeEngine` it
/// observes, so a change in Settings redraws it; a static helper, which has no instance to
/// observe through, reads the shared engine directly.
var offenders: [String] = []
for path in paths {
if try !source(of: path).contains("ThemeEngine.shared.valueFont") {
let text = try source(of: path)
if !text.contains("ThemeEngine.shared.valueFont"), !text.contains("themeEngine.valueFont") {
offenders.append(path)
}
}
Expand Down Expand Up @@ -167,7 +171,11 @@ struct ValueFontTests {
let source = try source(of: "TablePro/Views/Results/JSONCodeEditor.swift")

#expect(source.contains("onChange(of: colorScheme)"))
#expect(source.contains("onChange(of: AppSettingsManager.shared.editor)"))
/// Observed, not read off the shared instance. The value `onChange(of:)` compares is read
/// while the body is built, and a body that does not observe the settings is never rebuilt
/// when they change, so `onChange(of: AppSettingsManager.shared.editor)` never fired.
#expect(source.contains("@ObservedObject private var settingsManager = AppSettingsManager.shared"))
#expect(source.contains("onChange(of: settingsManager.editor)"))
#expect(source.contains("onReceive(AppEvents.shared.themeChanged)"))
#expect(source.contains("onReceive(AppEvents.shared.accessibilityTextSizeChanged)"))
}
Expand Down
Loading