chore: support instance-level default bundle id#50
Merged
maxy-shpfy merged 1 commit intoJul 1, 2026
Conversation
This was referenced Jul 1, 2026
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 1, 2026
maxy-shpfy
force-pushed
the
06-30-chore_egress_via_pre-configured_target_urls
branch
from
2762e47 to
185fda2
Compare
maxy-shpfy
force-pushed
the
07-01-chore_support_instance-level_default_bundle_id
branch
from
d3368ab to
4034364
Compare
maxy-shpfy
force-pushed
the
06-30-chore_egress_via_pre-configured_target_urls
branch
from
185fda2 to
1d61c69
Compare
maxy-shpfy
force-pushed
the
07-01-chore_support_instance-level_default_bundle_id
branch
from
4034364 to
18d3599
Compare
Collaborator
Author
Merge activity
|
maxy-shpfy
changed the base branch from
06-30-chore_egress_via_pre-configured_target_urls
to
graphite-base/50
maxy-shpfy
force-pushed
the
07-01-chore_support_instance-level_default_bundle_id
branch
from
18d3599 to
339bcb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The default session bundle ID is now configurable at container runtime rather than being baked into the image at build time.
What changed?
During the Vite build,
VITE_DEFAULT_SESSION_BUNDLE_IDis set to a placeholder string (__TANGENT_RUNTIME_DEFAULT_SESSION_BUNDLE_ID__) instead of a real value. At container startup,docker-entrypoint.shreplaces that placeholder across all built HTML, JS, and CSS files with the value ofVITE_DEFAULT_SESSION_BUNDLE_ID(defaulting totangleif not set). The entrypoint also validates that the provided value is a valid bundle ID slug (lowercase letters, numbers, and hyphens).The
PI_PROXY_URLenvironment variable declaration and its associated comments have been removed from the Dockerfile.How to test?
VITE_DEFAULT_SESSION_BUNDLE_ID— confirm the defaulttanglebundle ID is used.VITE_DEFAULT_SESSION_BUNDLE_ID=my-bundleand verify the placeholder is replaced correctly in the served assets.Why make this change?
Previously, the default session bundle ID was fixed at image build time, requiring a separate image build for each deployment targeting a different bundle default. By deferring the substitution to container startup, the same image can be reused across environments with different bundle defaults simply by setting an environment variable.