chore: remove vendor locked variables#52
Merged
Conversation
This was referenced Jul 1, 2026
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 1, 2026
maxy-shpfy
force-pushed
the
07-01-chore_clean_up_tangle-oss_bundle
branch
from
99e8451 to
b893883
Compare
maxy-shpfy
force-pushed
the
07-01-chore_remove_vendor_locked_variables
branch
from
b2db1bc to
8cffde3
Compare
maxy-shpfy
force-pushed
the
07-01-chore_clean_up_tangle-oss_bundle
branch
from
b893883 to
c1d66bd
Compare
maxy-shpfy
force-pushed
the
07-01-chore_remove_vendor_locked_variables
branch
2 times, most recently
from
47bc3f9 to
1d4f7f7
Compare
maxy-shpfy
force-pushed
the
07-01-chore_remove_vendor_locked_variables
branch
from
1d4f7f7 to
96d4d68
Compare
Collaborator
Author
Merge activity
|
maxy-shpfy
changed the base branch from
07-01-chore_clean_up_tangle-oss_bundle
to
graphite-base/52
maxy-shpfy
force-pushed
the
07-01-chore_remove_vendor_locked_variables
branch
from
96d4d68 to
f52765c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Removes the hardcoded Shopify proxy default URL and deletes the
instance.shDocker setup script.What changed?
PI_PROXY_URLinproxyProvider.tshas been changed from"https://proxy.shopify.ai"to an empty string, removing the implicit dependency on the Shopify proxy when the environment variable is not set.docker/instance.shhas been deleted entirely, removing the container bootstrap script that handled CA certificate setup, proxy configuration,uvinstallation, and environment variable initialization.How to test?
PI_PROXY_URLenvironment variable when provided.PI_PROXY_URLresults in an empty base URL rather than silently routing through the Shopify proxy.instance.sh.Why make this change?
The hardcoded Shopify proxy URL created an implicit coupling to internal infrastructure that should not be a default. Requiring
PI_PROXY_URLto be explicitly set makes the configuration intentional and avoids unintended routing. Theinstance.shscript has been removed as it is no longer needed for the current container setup.